Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Handle missing Element Call brand #9376

Merged
merged 2 commits into from
Oct 7, 2022
Merged

Handle missing Element Call brand #9376

merged 2 commits into from
Oct 7, 2022

Conversation

SimonBrandner
Copy link
Contributor

@SimonBrandner SimonBrandner commented Oct 7, 2022 •
edited by github-actions bot
Loading

Notes: none
Fixes #9347 (comment)

This change has no change notes, so will not be included in the changelog.

@SimonBrandner
Handle missing brand
46eabd3 
Signed-off-by: Šimon Brandner <[email protected]>
@SimonBrandner SimonBrandner added the T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems label Oct 7, 2022
@SimonBrandner SimonBrandner requested a review from a team as a code owner October 7, 2022 18:31
@SimonBrandner SimonBrandner mentioned this pull request Oct 7, 2022
Merged
robintown
robintown reviewed Oct 7, 2022
View reviewed changes
Copy link
Member

@robintown robintown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should update the SdkConfig types to reflect the fact that all the element_call subkeys are optional (and do the same for each subkey)

@SimonBrandner SimonBrandner merged commit 5680d13 into develop Oct 7, 2022
@SimonBrandner SimonBrandner deleted the SimonBrandner/fix/ec-brand branch October 7, 2022 19:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@robintown robintown robintown approved these changes

@germain-gg germain-gg Awaiting requested review from germain-gg germain-gg is a code owner automatically assigned from matrix-org/element-web-reviewers

@t3chguy t3chguy Awaiting requested review from t3chguy t3chguy is a code owner automatically assigned from matrix-org/element-web-reviewers

@kerryarchibald kerryarchibald Awaiting requested review from kerryarchibald kerryarchibald is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SimonBrandner @robintown