This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Improve URL previews #6326
Merged
Improve URL previews #6326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
only show 2 by default with expand/collapse mechanism show all hashes again, but dedup requests clean up hide mechanism, instead of one `x` per preview have one per group
t3chguy
changed the title
germain-gg
approved these changes
Jul 8, 2021
|
Really minor comment - Just to check please, does collapse hide the '3 other previews' or all the previews? I think 'hide' or 'hide previews' might be better English, as the opening is show, not expand. |
It takes you back to exactly how it looked before you clicked The hide interaction is the |
niquewoodhouse
approved these changes
Jul 8, 2021
|
We can tweak copy after playing with it |
… revert-6135-t3chguy/fix/17494
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #6135
Requires matrix-org/matrix-js-sdk#1721
Fixes element-hq/element-web#5433
Fixes element-hq/element-web#17889
Fixes element-hq/element-web#5877
Fixes element-hq/element-web#13711
Fixes element-hq/element-web#13143
Based on designs in element-hq/element-web#5433 (comment)