Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hiding one link preview in a message hides all link previews #5877

Closed
NotAFile opened this issue Dec 25, 2017 · 0 comments · Fixed by matrix-org/matrix-react-sdk#6326
Closed

Hiding one link preview in a message hides all link previews #5877

NotAFile opened this issue Dec 25, 2017 · 0 comments · Fixed by matrix-org/matrix-react-sdk#6326
Assignees
@t3chguy
Labels
A-URL-Previews P2 S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Needs-Design

Comments

@NotAFile
Copy link
Contributor

Description

When pressing "X" on a link preview from a message with multiple links, all previews disappear.

Steps to reproduce

  • Send message with multiple links
  • press "X" to hide preview

I think either only the single link preview should disappear, or instead the "X" should be shown per message, not per link.

Version information

  • Platform: web
  • Browser: Firefox 59
  • OS: Linux
  • URL: riot.im/app/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t3chguy t3chguy

Labels
A-URL-Previews P2 S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Needs-Design
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve URL previews matrix-org/matrix-react-sdk
4 participants
@jryans @lampholder @t3chguy @NotAFile