Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit the number of URL previews. #5433

Closed
turt2live opened this issue Oct 25, 2017 · 5 comments · Fixed by matrix-org/matrix-react-sdk#6326
Closed

Limit the number of URL previews. #5433

turt2live opened this issue Oct 25, 2017 · 5 comments · Fixed by matrix-org/matrix-react-sdk#6326
Assignees
Labels
A-URL-Previews P2 S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@turt2live
Copy link
Member

turt2live commented Oct 25, 2017

Bountysource

Description

image
https://matrix.to/#/!UcYsUzyxTGDxLBEvLz:matrix.org/$1508940221476bTcDp:berigora.net
(#offtopic)

Version information

  • Platform: web (in-browser)
  • Browser: Chrome 62
  • OS: Windows 10
  • URL: riot.im/develop
@lampholder
Copy link
Member

😱 🙀 amazing 😬

Yeah, I guess limiting it to... actually maybe limiting it to one would be good (and easy to remember). Maybe something like:

image
(That's actually ugly as hell, but, you know, something like that). It could even optionally click to expand.

@lampholder lampholder added T-Defect S-Minor Impairs non-critical functionality or suitable workarounds exist P2 ui/ux labels Oct 26, 2017
@turt2live
Copy link
Member Author

I kinda don't mind that, would something like this also work?
image
(please ignore the fact that I was too lazy to get the color code for riot text - it should be Riot green)

Showing 2 previews seems reasonable, as it isn't too bad on the timeline. 3 would probably be too many though. The only other significant things I changed were the text (to give the user a hint as to what clicking it does) and disconnected the left edge from the preview itself.

@lampholder
Copy link
Member

Yeah, I like that. The reason I chose one rather than more-than-one was because I thought it would be super easy for people to remember - if they want to post three links with URL previews that's going to be three individual messages.

I'm not super wedded to that though - anything which puts a reasonable limit on it and lets people expand to see the full list is good I think.

The risk with expanding/contracting timeline items is that they leave you in a place in the timeline tha you didn't expect to be pre/post expansion/contraction - if we can impl a solution for this without falling into that trap, I think this would be a good thing to do :)

@turt2live
Copy link
Member Author

Updated original post for the bounty :)

@t3chguy
Copy link
Member

t3chguy commented Feb 16, 2018

I think I'll take this on, I personally prefer 2 but I'll do it in a way where the number is just a const atop the file for easy tweaking l8r

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-URL-Previews P2 S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants