Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Override UA/OS styles for disabled Field selects #2502

Merged
merged 2 commits into from
Jan 28, 2019
Merged

Override UA/OS styles for disabled Field selects #2502

merged 2 commits into from
Jan 28, 2019

Conversation

turt2live
Copy link
Member

Fixes element-hq/element-web#8249

Before:
image

After:
image

@turt2live turt2live requested a review from a team January 25, 2019 02:28
@turt2live turt2live mentioned this pull request Jan 25, 2019
Closed
40 tasks
@bwindels bwindels self-assigned this Jan 25, 2019
bwindels
bwindels approved these changes Jan 25, 2019
View reviewed changes
Copy link
Contributor

@bwindels bwindels left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixes the label problem, but it's not really clear any more that the field is disabled though...
maybe we can make the text in the dropdown lighter or something?

@turt2live turt2live requested a review from bwindels January 25, 2019 16:10
@turt2live
Copy link
Member Author

@bwindels please take another look. I've added a grey colour and applied it to regular inputs as well. Here's the result:

image

@jryans jryans mentioned this pull request Jan 25, 2019
Closed
@turt2live turt2live merged commit c204cd7 into experimental Jan 28, 2019
@turt2live turt2live deleted the travis/settings/disabled-selects branch January 28, 2019 17:32
@turt2live turt2live mentioned this pull request Jan 28, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bwindels bwindels bwindels approved these changes

Assignees

@bwindels bwindels

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@turt2live @bwindels