Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign: Need design for field selects #8264

Closed
turt2live opened this issue Jan 25, 2019 · 8 comments
Closed

Redesign: Need design for field selects #8264

turt2live opened this issue Jan 25, 2019 · 8 comments
Assignees

Comments

@turt2live
Copy link
Member

turt2live commented Jan 25, 2019

Need a design to determine exactly what they should look like.

For example on macOS they look completely wrong:
image

On windows they look like this:
image

@jryans
Copy link
Collaborator

jryans commented Jan 25, 2019

Isn't this a duplicate of #8249? (The proposed fix in matrix-org/matrix-react-sdk#2502 hasn't merged.)

@turt2live
Copy link
Member Author

Nope, matrix-org/matrix-react-sdk#2502 doesn't address how the fields are outright wrongly represented on macOS (see image).

@jryans
Copy link
Collaborator

jryans commented Jan 25, 2019

Ah okay, I wasn't sure how far we wanted to go in terms of controlling style across UAs. (As mentioned before, there's no design spec for <select> currently...)

@turt2live
Copy link
Member Author

Yea, I'll adopt this issue as the canonical "figure out selects" issue

@turt2live turt2live changed the title Redesign: Field selects look wrong on Chrome on macOS Redesign: Need design for field selects Jan 25, 2019
@ara4n
Copy link
Member

ara4n commented Jan 26, 2019

my recommendation for this would be to use a non-native select control, like LanguageDropdown already provides - as otherwise the native selects vary massively between platform and simply aren't reliably skinnable. Then, aesthetically, we just ape the Field look & feel.

@ara4n
Copy link
Member

ara4n commented Jan 30, 2019

@turt2live points out that implementing all the accessibility stuff with a non-native select is a pain in the ass, and it turns out that we do have enough CSS these days to override the look & feel of the native select control on webkit & firefox:

https://jsfiddle.net/pxjkqru9/2 <-- n.b. v2

If someone (@jryans? @turt2live?) can apply it to the selects to make them non-fugly it'd be appreciated (or i may have time later today to do it, but would rather it wasn't blocked on me)

@jryans jryans self-assigned this Jan 30, 2019
@jryans
Copy link
Collaborator

jryans commented Jan 30, 2019

I'll take a look.

@jryans
Copy link
Collaborator

jryans commented Jan 31, 2019

Fixed by matrix-org/matrix-react-sdk#2540.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants