Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chevron is broken for LanguageDropdown #8339

Closed
ara4n opened this issue Jan 31, 2019 · 5 comments
Closed

chevron is broken for LanguageDropdown #8339

ara4n opened this issue Jan 31, 2019 · 5 comments
Assignees
Labels
P1 S-Minor Impairs non-critical functionality or suitable workarounds exist S-Tolerable Low/no impact on users T-Defect

Comments

@ara4n
Copy link
Member

ara4n commented Jan 31, 2019

Should we switch this over to being a normal ? Originally this was a custom component so that it could have flags - but languages categorically don't have flags.

@ara4n
Copy link
Member Author

ara4n commented Jan 31, 2019

screenshot 2019-01-31 at 12 31 54

@ara4n
Copy link
Member Author

ara4n commented Jan 31, 2019

(chevron should be on RHS)

@lampholder
Copy link
Member

Looks like we use this component on the login page, too (choosing your login mechanism suffers from the same misplaced chevron).

@lampholder lampholder added T-Defect ui/ux P1 S-Minor Impairs non-critical functionality or suitable workarounds exist S-Tolerable Low/no impact on users labels Jan 31, 2019
@jryans
Copy link
Collaborator

jryans commented Jan 31, 2019

This is the Dropdown component that has been around a while. The arrow icon was recently updated, so perhaps the position regressed when that happened.

There is also a new Field component which (when used as a <select>) also has a dropdown arrow that we just tuned to be on the right with the identical arrow icon.

So, we currently have two dropdown components with the same arrow icon, but Field will use native select / options, while Dropdown is all custom so it can include images and such.

So it looks like here we should:

  • FIx Dropdown to push the arrow to the right again
  • Possibly switch this language selector to Field because it doesn't show fancy things like flags

@jryans
Copy link
Collaborator

jryans commented Feb 1, 2019

I fixed the Dropdown chevron position in matrix-org/matrix-react-sdk#2564.

Let's consider switching away from Dropdown for languages as a separate task.

@jryans jryans closed this as completed Feb 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 S-Minor Impairs non-critical functionality or suitable workarounds exist S-Tolerable Low/no impact on users T-Defect
Projects
None yet
Development

No branches or pull requests

3 participants