Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Settings Redesign: Label on theme control looks strange #8249

Closed
jryans opened this issue Jan 24, 2019 · 6 comments
Closed

Settings Redesign: Label on theme control looks strange #8249

jryans opened this issue Jan 24, 2019 · 6 comments
Assignees
@turt2live
Labels
S-Tolerable Low/no impact on users T-Defect

Comments

@jryans
Copy link
Collaborator

jryans commented Jan 24, 2019

Maybe we should remove the label from the theme control?

image
@jryans jryans added T-Defect S-Tolerable Low/no impact on users defect labels Jan 24, 2019
@turt2live turt2live mentioned this issue Jan 24, 2019
Closed
40 tasks
@turt2live
Copy link
Member

It looks fine over here :(

I think this is partly because there's no final design for dropdowns (on that same page there's 2 kinds of dropdowns) - have added to the list of things to check up on once this all lands.

@jryans
Copy link
Collaborator Author

jryans commented Jan 24, 2019 •
edited
Loading

It looks fine over here :(

What does it look like for you? For me, Firefox and Chrome on macOS seem to both show issues like the screenshot above.

@turt2live
Copy link
Member

image

I guess there's just not enough styles being changed on selects?

@jryans
Copy link
Collaborator Author

jryans commented Jan 24, 2019 •
edited
Loading

I think the style of select:disabled is UA and OS specific, so we may want to force the background-color to white for fields.

@turt2live
Copy link
Member

Ah, good call. I've put it on the CSS touchups list - if someone beats me to it, that's great :)

@turt2live turt2live self-assigned this Jan 25, 2019
turt2live added a commit to matrix-org/matrix-react-sdk that referenced this issue Jan 25, 2019
@turt2live
Override UA/OS styles for disabled Field selects
284be26 
Fixes element-hq/element-web#8249
@turt2live turt2live mentioned this issue Jan 25, 2019
Merged
@jryans jryans mentioned this issue Jan 25, 2019
Closed
@turt2live
Copy link
Member

Fixed by matrix-org/matrix-react-sdk#2502

More work to do, however. Tracked here: #8264

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@turt2live turt2live

Labels
S-Tolerable Low/no impact on users T-Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jryans @turt2live