Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wireit sass watch memory leak #4506

Merged

Conversation

vdegenne
Copy link
Contributor

This will avoid wireit looping through the @material/web symbolic link in watch mode.

@asyncLiz asyncLiz requested a review from e111077 June 28, 2023 18:21
@e111077
Copy link
Contributor

e111077 commented Jun 28, 2023

OMG wow! great find!

@vdegenne
Copy link
Contributor Author

@e111077 wait!

@copybara-service copybara-service bot merged commit 8270da2 into material-components:main Jun 28, 2023
@e111077
Copy link
Contributor

e111077 commented Jun 28, 2023

if there's a change you need to be made, you'll need to start another PR since the merge process is largely automated

@vdegenne
Copy link
Contributor Author

@e111077 No I just wanted to say this solution works in the case where catalog is removed from workspaces and has its own node_modules directory.
Accepting this change in the current state of this repo will actually have no effect, it's still good for prevention though.

IMO yesterday @augustjk's PR ( #4501) is a better solution but one needs to be aware it only works if package-lock.json is removed before npm i.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants