fix: catalog dev watch memory leak #4509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This value is no longer required.
|
@augustjk Requesting a review from you since we've discussed about this issue together. |
|
I think an |
e111077
suggested changes
Jun 29, 2023
e111077
approved these changes
Jun 30, 2023
|
Cool, sent for internal review. Unfortunately I can't approve it because I imported it, and it's currently outside of regular working hours, so someone should approve it tomorrow and the bot should merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #4506 which didn't really solve the memory leak, just slowed it down.
This PR really solves the memory leak problem which originated from the
copy-storieswireit task in thecatalogpackage.../*/demovalue infilesfield was expanding to../node_modules/...paths, causing the loop.