fix(repo): remove "." from workspace config #4501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e111077
approved these changes
Jun 26, 2023
e111077
changed the title
augustjk
force-pushed
the
update-workspace-config
branch
from
4d39df5 to
d436c8f
Compare
|
amended commit to have no uppercase and force pushed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
"."in workspaces config seems to create an infinite recursive symlink as seen here google/wireit#790It looks unnecessary to include the root directory in the workspaces config. No commands in the repo currently use the
--workspaceor--workspacesflag for npm commands so those commands should not be affected.If there were
--workspacesflags meant to run a command for all workspace directories, the root directory can be included by--include-workspace-rootflag as well. https://docs.npmjs.com/cli/v8/commands/npm-run-script#include-workspace-root@material/webuse within thecatalogworkspace still correctly resolves to the root package with the reference, and does not install its own copy from npm.