-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(fab): Made initRipple and unbounded props optional #810
fix(fab): Made initRipple and unbounded props optional #810
Conversation
@Maxim-Mazurok it looks like tests are failing. Could you please provide a fix for those? Thanks! |
I thought that tests failed because the previous build also failed. I will run tests locally later to figure out what happened. |
https://travis-ci.com/material-components/material-components-web-react/jobs/193054458 It looks like you're getting TS FabProp errors. Sounds good - thanks! |
fixes #841 |
Sorry for leaving this PR without updates for a while. |
@Maxim-Mazurok no worries - thanks for making the changes. LMK if you need anything. |
BREAKING CHANGE: Text-field, select, list have API changes. Please see PR #830 for more details.
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the ℹ️ Googlers: Go here for more info. |
Codecov Report
@@ Coverage Diff @@
## rc0.12.0 #810 +/- ##
=========================================
Coverage 94.47% 94.47%
=========================================
Files 81 81
Lines 3475 3475
Branches 532 532
=========================================
Hits 3283 3283
Misses 66 66
Partials 126 126
Continue to review full report at Codecov.
|
@Maxim-Mazurok there are a few conflicts occurring now. Please update when you get a chance. Thanks! |
This PR is a follow up to this conversation: b62c36f#r33164756
initRipple
andunbounded
props should be optional.