Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fab): Made initRipple and unbounded props optional #810

Closed
wants to merge 12 commits into from
Closed

fix(fab): Made initRipple and unbounded props optional #810

wants to merge 12 commits into from

Conversation

Maxim-Mazurok
Copy link
Contributor

This PR is a follow up to this conversation: b62c36f#r33164756

initRipple and unbounded props should be optional.

@moog16 moog16 changed the base branch from master to rc0.12.0 April 15, 2019 16:47
@moog16
Copy link

moog16 commented Apr 16, 2019

@Maxim-Mazurok it looks like tests are failing. Could you please provide a fix for those? Thanks!

@Maxim-Mazurok
Copy link
Contributor Author

I thought that tests failed because the previous build also failed. I will run tests locally later to figure out what happened.

@moog16
Copy link

moog16 commented Apr 16, 2019

https://travis-ci.com/material-components/material-components-web-react/jobs/193054458

It looks like you're getting TS FabProp errors.

Sounds good - thanks!

@moog16
Copy link

moog16 commented May 2, 2019

fixes #841

@Maxim-Mazurok
Copy link
Contributor Author

Sorry for leaving this PR without updates for a while.
I took a look and it seems that this change is not as easy as I thought originally, it breaks a lot of stuff. Needs further investigation, so I'll try to find time for it in the next couple of days.

@moog16
Copy link

moog16 commented May 3, 2019

@Maxim-Mazurok no worries - thanks for making the changes. LMK if you need anything.

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no and removed cla: yes labels May 6, 2019
@codecov-io
Copy link

Codecov Report

Merging #810 into rc0.12.0 will not change coverage.
The diff coverage is 92.18%.

Impacted file tree graph

@@            Coverage Diff            @@
##           rc0.12.0     #810   +/-   ##
=========================================
  Coverage     94.47%   94.47%           
=========================================
  Files            81       81           
  Lines          3475     3475           
  Branches        532      532           
=========================================
  Hits           3283     3283           
  Misses           66       66           
  Partials        126      126
Impacted Files Coverage Δ
packages/checkbox/NativeControl.tsx 100% <100%> (ø) ⬆️
packages/drawer/AppContent.tsx 66.66% <100%> (ø) ⬆️
packages/select/Option.tsx 100% <100%> (ø) ⬆️
packages/tab/TabRipple.tsx 100% <100%> (ø) ⬆️
packages/chips/ChipCheckmark.tsx 80% <100%> (ø) ⬆️
packages/dialog/DialogTitle.tsx 100% <100%> (ø) ⬆️
packages/menu/MenuList.tsx 100% <100%> (ø) ⬆️
packages/card/ActionButtons.tsx 92.3% <100%> (ø) ⬆️
packages/icon-button/index.tsx 97.91% <100%> (ø) ⬆️
packages/dialog/index.tsx 97.9% <100%> (ø) ⬆️
... and 94 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7c5233...47979ad. Read the comment docs.

@moog16 moog16 changed the base branch from rc0.12.0 to rc0.13.0 May 6, 2019 15:44
@moog16
Copy link

moog16 commented May 6, 2019

@Maxim-Mazurok there are a few conflicts occurring now. Please update when you get a chance. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants