Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fab): Made initRipple and unbounded props optional #854

Merged
merged 1 commit into from
May 8, 2019

Conversation

Maxim-Mazurok
Copy link
Contributor

Reopening #810

This PR is a follow up to this conversation: b62c36f#r33164756

initRipple and unbounded props should be optional.

@codecov-io
Copy link

codecov-io commented May 6, 2019

Codecov Report

Merging #854 into rc0.13.0 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           rc0.13.0    #854   +/-   ##
========================================
  Coverage      94.5%   94.5%           
========================================
  Files            85      85           
  Lines          3496    3496           
  Branches        532     532           
========================================
  Hits           3304    3304           
  Misses           66      66           
  Partials        126     126
Impacted Files Coverage Δ
packages/fab/index.tsx 92.59% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2fde6c...3e8ad8a. Read the comment docs.

@Maxim-Mazurok
Copy link
Contributor Author

rc0.13.0 branch is also failing on screenshot tests on my local environment without this PR changes, so I'll just wait till tests are fixed in rc0.13.0.
The only error in Travis was "Error: Timeout of 60000ms exceeded", so the test might be flaky and rerunning build might fix the issue.

@moog16
Copy link

moog16 commented May 8, 2019

Just restarted it. Sometimes travisCI gets slow. And sometimes we need to add some more time to the startup of the webpack server. I hope it doesn't come to that, as we're waiting around 45 seconds for startup now.

@moog16 moog16 merged commit 39ced34 into material-components:rc0.13.0 May 8, 2019
@moog16
Copy link

moog16 commented May 8, 2019

Thanks @Maxim-Mazurok !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants