-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correction to README file #799
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Codecov Report
@@ Coverage Diff @@
## rc0.12.0 #799 +/- ##
=========================================
Coverage 95.14% 95.14%
=========================================
Files 73 73
Lines 2924 2924
Branches 449 449
=========================================
Hits 2782 2782
Misses 46 46
Partials 96 96 Continue to review full report at Codecov.
|
… bounded ripple The current documentation leads the reader to create an unbounded ripple, extending outside the dimensions of the component (even when the `unbounded` prop is removed). The `overflow: hidden` property must be added to render the expected bounded ripple effect. Thank you a
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
Second commit to this PR: At Line 30 of README documentation: Advise reader to add The current documentation leads the reader to create an unbounded ripple, extending outside the dimensions of the component (even when the Thank you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - thanks for fixing!
Hello, there is an error in this documentation. At line 23, reader is advised to add:
This file does not exist.
User should be advised to add:
Thank you
a