-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address accessibility issues #11064
Address accessibility issues #11064
Conversation
…ed on markers with popups
aria-pressed
with aria-expanded
on the attribution control
#11034
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this looks great. The only reservation I have is removing the title
attribute — I'm wondering if this also removes the tooltip that's shown when hovering the control, and if so, whether we should try the suggestion in the reported issue instead (where title
and aria-label
are put on different nested elements) so that we keep the current behavior.
@mourner I checked it out and it did remove the native tooltips. I used the nested element as suggested to add the title attribute, and tooltips now work as expected. Thanks! |
* main: Add touch pan blocker to gesture handling for touch devices (#11116) Address accessibility issues (#11064) add support for non-mercator projections (#11124) Image fallback expressions within paint properties (#11049) Replaces EPSG:4326 with OGC:CRS84 in GL JS `LngLat` doc (#11072) Add globe view support to heatmap shaders (#11120) Exclude flaky test (#11118) consistify YOUR_MAPBOX_ACCESS_TOKEN as placeholder string (#11113) Allow adding multiple layers to `map.on()` event handler (h/t @omerbn) (#11114) render-test-flakiness:clear worker storage (#11111) upgrade to supercluster v7.1.4, earcut v2.2.3, vt-pbf v3.1.3, geojson-rewind v0.5.1 (#11110) Added v1.13.2 changelog entry (#11108) One weird JSON.parse() trick (#11098) Fixed doc usage of map.getCenter (#11093) s̶y̶m̶b̶o̶l̶-̶c̶l̶i̶p̶ dynamic-filtering with `pitch` and `distance-from-camera` expressions (#10795) Update link to transpiling guide (#11096) Cherry pick 2.5.1 changelog (#11099) Fix an iOS15 issue where Safari tab bar interrupts panning (#11084) Fix conditional check for isFullscreen to accommodate Safari (#11086) Render tests for #11041 (#11070)
Addresses accessibility milestone issues: #11036, #11034, #11032, and #11031.
[accessibility] Consider conveying only one of
aria-label
andtitle
in controls #11036 Removes title in preference for only using aria-label in controls. Some screen-readers will announce both title and aria-label. Docs on aria-label, accessibility concerns with using title attribute.[accessibility] Consider replacing
aria-pressed
witharia-expanded
on the attribution control #11034 Aria-pressed on attribution control is replaced with aria-expanded. Aria-expanded indicates that a grouping of other elements is displayed ("expanded") or hidden ("collapsed"). Here is the difference between aria-pressed and aria-expanded[accessibility] Interactive markers should convey the
aria-expanded
state of the controlled popup #11032 Interactive markers with popups should also use aria-expanded to reveal if the state of the marker is expanded or collapsed.[accessibility] Interactive markers should be
role="button"
#11031 role="button" should be set on interactive markers (aka markers with popups). Setting role="button" reveals that the element is clickable to screen readers. Docs on role buttonLaunch Checklist