Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[accessibility] Interactive markers should have a default accessible name #11030

Closed
Malvoz opened this issue Sep 18, 2021 · 2 comments · Fixed by #11349
Closed

[accessibility] Interactive markers should have a default accessible name #11030

Malvoz opened this issue Sep 18, 2021 · 2 comments · Fixed by #11349
Assignees
Milestone

Comments

@Malvoz
Copy link

Malvoz commented Sep 18, 2021

Interactive markers (e.g. markers that bind to popups) should have a default accessible name, e.g. aria-label="Marker" if not specified.

Related WCAG 2.1 Success Criterion: 4.1.2 Name, Role, Value (this issue is to address the Name part of the Success Criterion for interactive markers).


Furthermore, ideally developers should ensure that each marker has a unique and descriptive name, such that the user can know what the marker is visually highlighting (in the case of markers binding to popups it'd also allow AT users to know what it's for before opening the popup). For example, the marker in https://docs.mapbox.com/mapbox-gl-js/example/set-popup/ would ideally be named "Washington Monument" or similar. Perhaps developers can be warned if markers are not uniquely named?

@Malvoz Malvoz changed the title Interactive markers should have a default accessible name [accessibility] Interactive markers should have a default accessible name Sep 18, 2021
@mourner mourner added this to the accessibility milestone Sep 20, 2021
@mourner
Copy link
Member

mourner commented Sep 20, 2021

Thanks so much for the thorough evaluations and hints @Malvoz! I've put all these issues in the accessibility milestone — seems like a lot of low-hanging fruits we could address quickly https://github.com/mapbox/mapbox-gl-js/milestone/48

@avpeery avpeery self-assigned this Sep 24, 2021
@avpeery avpeery linked a pull request Sep 29, 2021 that will close this issue
5 tasks
@avpeery avpeery removed a link to a pull request Sep 29, 2021
5 tasks
@fergcody06
Copy link

fergcody06 commented Dec 17, 2021

We recently updated our Mapbox version to v2.6.0 to resolve a WCAG issue we were seeing where role="button" needed to be added to the markers. That issue is now resolved but it introduced a new WCAG issue where Aria buttons must be accompanied by an accessible name. This issue will solve that. Does anyone know when this is going out? I see it was added to the same PR that had the role="button" fix but was then removed before the merge to main branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants