Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements
https://www.youtube.com/watch?v=ff4fgQxPaO0
for the style spec json only. This doesn't implement it for other json objects because with those we would still like to have treeshaking.
The theory is that a static
JSON.parse(large_json_string)
is much faster than having alarge_json_object
,this is because alarge_json_object
is parsed by the full JavaScript parser since it can't know ahead of time if an object is pure-json.With this change the JS parser skips that entire section since all it sees is a single string. The dedicated json parser underneath
JSON.parse
can then handle it much faster.Benchmap is showing a negligible but detectible improvement in
workerEvaluateScript
which is exactly where we expect to see an improvement.