-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No symbols shown when using GeoJSON with Mapbox newer then 0.11.1 #1792
Comments
I can confirm this is a bug introduced in v0.11.2. It could be related to any of (or none of)
HINDSIGHT EDIT: it was related to none of these 😬 |
Let's do git bisect.
Vladimir Agafonkin |
Bisects to 3532d80, which specifically mentions 1-way arrows.
In this case, the arrows are set to show between zoom levels 15 and 22 but are not being displayed at zoom 18. |
Because the default maxzoom for GeoJSON sources is 14, these one way arrows are not being rendered at zoom levels 15 to 22. @mourner Do you think there's an actionable fix there? Should we increase the default zoom of GeoJSON sources? Add some additional logic? @buma You can fix the problem by adding |
@buma Here's a modified jsbin with the suggested fixes in place. Happy mapping! 🌐 |
@lucaswoj ah, yeah, I think we should bump it to at least 16 which is what Mapbox Streets v7 uses, but can go deeper (say 18) — it won't affect performance noticeably. |
@mourner Does the source's |
That was fast! Thanks to all of you it works great now! But it seems there should be a FAQ or documentation about GeoJSON default maxzoom or it should be changed. |
If I use GeoJSON with custom symbols or symbols from mapbox symbol set none of them are shown if I use Mapbox gl/js newer then 0.11.1.
On jsbin I put minimal sample. It has much smaller geojson which shows that oneway icons are shown at least on two edges but they should be on all. But if I update mapbox version to 0.11.2 for js and css they aren't shown on any edge.
It is probably similar issue to #1563 but the text labels are rendered even on newer mapbox versions not on all edges but at least on same number as in version 0.11.1.
Rendering of symbols from mapbox works even on newer versions if I use mapbox tiles instead of GeoJSON. I don't know about custom symbols I tested Mapbox street layer.
The text was updated successfully, but these errors were encountered: