Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

raster layer with opacity < 1 flickers to full opacity #1270

Closed
Tracked by #229
anandthakker opened this issue Jun 12, 2015 · 5 comments · Fixed by #1895
Closed
Tracked by #229

raster layer with opacity < 1 flickers to full opacity #1270

anandthakker opened this issue Jun 12, 2015 · 5 comments · Fixed by #1895
Assignees
@ansis

Comments

@anandthakker
Copy link
Contributor

With opacity for a raster layer set at 0.4, after changing zoom, I sometimes see tiles with full opacity. Usually just moving the mouse causes the opacity to snap into place.

Also showed this to @samanpwbb
@samanpwbb
Copy link
Contributor

Seeing a lot of this:

screen shot 2015-06-12 at 6 23 37 pm
screen shot 2015-06-12 at 6 23 26 pm

@anandthakker
Copy link
Contributor Author

BTW, I also saw #675 -- that issue's pretty old, but maybe it's related

cc @mourner

@lucaswoj
Copy link
Contributor

I'm guessing that we're doing a bad job of fading between two raster tiles at intermediate zoom levels. If raster-opacity is 0.4, there are two tiles of opacity 0.4 on top of each other instead of one tile of opacity 0.4.

@tmcw
Copy link
Contributor

tmcw commented Oct 5, 2015

Also seeing this: any opacity value but 0 makes tiles opaque

This was referenced Oct 8, 2015
Closed
Closed
Closed
Closed
Closed
Open
bhousel added a commit that referenced this issue Oct 10, 2015
@bhousel
Apply raster-opacity to non-tile sources
6a35e31 
(related #1270)
@bhousel bhousel mentioned this issue Oct 10, 2015
Merged
@bhousel
Copy link
Contributor

bhousel commented Oct 10, 2015

#1610 maybe fixes the thing @tmcw mentioned above, but probably not the main flickering issue.

bhousel added a commit that referenced this issue Oct 16, 2015
@bhousel @jfirebaugh
Apply raster-opacity to non-tile sources
c081841 
(related #1270)
@lucaswoj lucaswoj mentioned this issue Dec 3, 2015
Closed
This was referenced Jan 4, 2016
Closed
Merged
ansis added a commit that referenced this issue Jan 6, 2016
@ansis
fix raster tile flickering
a6604ab 
fixes #1270

Use the depth buffer to prevent double drawing in areas where raster
tiles overlap.
@ansis ansis mentioned this issue Jan 6, 2016
Merged
@ansis ansis self-assigned this Jan 6, 2016
ansis added a commit that referenced this issue Jan 6, 2016
@ansis
fix raster tile flickering
6171a2f 
fixes #1270

Use the depth buffer to prevent double drawing in areas where raster
tiles overlap.
@ansis ansis removed the in progress label Jan 6, 2016
@danbjoseph danbjoseph mentioned this issue Jan 25, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ansis ansis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix raster fading and blank areas mapbox/mapbox-gl-js
6 participants
@tmcw @bhousel @samanpwbb @lucaswoj @ansis @anandthakker