-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
POI icons don't show up when page zoom is not 100% on page load #1476
Comments
On OS X, I was not able to replicate this issue in Safari Version 8.0.8 but was able to replicate the issue in Chrome Version 45.0.2454.85. |
Because it works in some browsers, I might start by looking at weird WebGL + page zoom interactions before I started looking for bugs in Mapbox GL JS. |
... that, or pixel density
https://github.com/mapbox/mapbox-gl-js/search?utf8=✓&q=devicePixelRatio |
@fnicollet I think I fixed this with #1593. Please re-open this ticket and ping me if you're still seeing the bug. |
ref #1851 Fix pattern and icon rendering when pattern resolution does not match devicePixelRatio.
I am getting this issue in Chrome 60 (only Chrome) only on Windows 10, only on some machines. I'm using a PNG as an icon, I can see it loading and follow the direct link in the browser, however mapbox is sometimes not rendering it. |
Hello,
I have just found a weird issue in mapbox-gl-js. If you load it while the page is zoomed out (say 90%), texts appear but icons are not showing up. If you load mapbox-gl-js while page is 100% and then zoom out 90%, icons are correctly displayed.
instead of
Here is a jsfiddle for you to reproduce the issue:
http://jsfiddle.net/fnicollet/u84yapaj/
I started looking in the code but I can't seem to find the issue. There are some icon drawSymbol calls with no error, it just doesn't show. I can't find where there is code looking for pixel density or anything.
Do you have an idea why this bug is happening or a hint on where I should look in the code?
Thanks a lot,
Fabien
The text was updated successfully, but these errors were encountered: