Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add automated testing for pytest through GitHub Actions #55

Merged
merged 3 commits into from
Nov 6, 2024

Conversation

d33bs
Copy link
Collaborator

@d33bs d33bs commented Sep 24, 2024

This PR adds automated testing for pytest through GitHub Actions on PR and push to the main branch as a prerequisite of #52. These tests have a chance of not running on this PR due to this being my first contribution to this repository (a GitHub security constraint). I've attempted to test this workflow as best as possible (manually, as attempting to use act resulted in errors related to actions/setup-python#401).

While I was working through this I noticed there was no CONTRIBUTING.md or CODE_OF_CONDUCT.md. I've added these with some template information that has been slightly modified to meet the needs here.

Please don't hesitate to let me know if you have any questions - look forward to any feedback you may have!

Closes #53

Copy link
Collaborator

@miltondp miltondp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic, @d33bs! Thanks for adding those missing files with the guidelines for contributing and the code of conduct. They look great. I wonder if we should enable Discussions in this project.

I'm having some internet issues on campus, so I'll try to post this comment for now and continue later.

@cgreene
Copy link
Contributor

cgreene commented Sep 25, 2024

Can we add a license here? Re: #58 - somewhat time sensitive (this week would be great) as we're trying to wrap up the final progress report for this grant.

@miltondp
Copy link
Collaborator

Yep, we can definitely add a licence. @d33bs could you pick one suggested by Casey here? The 3-clause BSD sounds like a good option.

@d33bs
Copy link
Collaborator Author

d33bs commented Sep 25, 2024

Sure thing @miltondp ! I noticed that the setup.py already includes a license mention: BSD-2-Clause Plus Patent. Should we plan to change from that license to the BSD-3-clause, or retain the BSD-2-Clause Plus Patent?

@miltondp
Copy link
Collaborator

Let's use what Casey suggested: BSD-3-clause. We might want to create another PR with the licence change and merge it quickly, so we don't rush things in this PR. Thank you, Dave!

@d33bs
Copy link
Collaborator Author

d33bs commented Nov 6, 2024

Thanks @miltondp and @cgreene for taking a look at this PR, thank you @falquaddoomi for the review approval! Merging this in now.

@d33bs d33bs merged commit c74f9c7 into manubot:main Nov 6, 2024
@d33bs d33bs deleted the add-gh-actions-tests branch November 6, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add automated tests for pytest through GitHub Actions
4 participants