Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from setup.py to Poetry pyproject.toml for packaging and environment management #57

Merged
merged 10 commits into from
Dec 11, 2024

Conversation

d33bs
Copy link
Collaborator

@d33bs d33bs commented Sep 24, 2024

This PR migrates from a setup.py file to a Poetry-flavor pyproject.toml file for packaging and environment management of this project. I've also added a pre-commit check which ensures the pyproject.toml file and poetry.lock file are in good form for possible changes as things grow with this package.

As part of this effort I also added https://github.com/rhysd/actionlint, https://github.com/tox-dev/pyproject-fmt, https://github.com/python-poetry/poetry (poetry-check) pre-commit checks to help ensure the work is well prepared and keeps consistent over time.

Thanks for any feedback you may have!

Depends on and should be merged after #55
Addresses the first step of #52

@d33bs d33bs marked this pull request as ready for review December 5, 2024 16:36
pyproject.toml Outdated Show resolved Hide resolved
Copy link
Collaborator

@falquaddoomi falquaddoomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really glad to see the project moving over to Poetry! I made a few comments to do with version pinning and the OpenAI API key, but otherwise this looks great.

pyproject.toml Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
d33bs and others added 3 commits December 11, 2024 12:49
Co-authored-by: Faisal Alquaddoomi <[email protected]>
Co-authored-by: Faisal Alquaddoomi <[email protected]>
@d33bs
Copy link
Collaborator Author

d33bs commented Dec 11, 2024

Thank you @miltondp and @falquaddoomi for your reviews! Merging this in now.

@d33bs d33bs merged commit ac0a6c1 into manubot:main Dec 11, 2024
7 checks passed
@d33bs d33bs deleted the setuppy-to-poetry branch December 11, 2024 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants