Cleanups & Refinements #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
naszam
commented
Feb 13, 2023
naszam
commented
- Cleanups & Refinements following Utilizes rollfork to obsolete deploy-info script spells-goerli#166
naszam
added a commit
that referenced
this pull request
Apr 15, 2023
* Revert "Cleanups & Refinements (#10)" This reverts commit 4bdc4fa. * cleanup * update readme * static interface checks + cleanups * add risk parameter changes checklists * update wordlist * fix teleport onboarding file name * fix teleport onboarding file name in readme * add rates manual check via script * typos * fix + cleanup spell crafter goerli * add community repo link + refinements to spell mainnet checklists * only list static interfaces functions used in spell code * more match typos * static description on goerli spell * avoid using same deployer for mainnet and testnets * check if contract requires rely the ESM for ES denyProxy keeper tasks * update wordlist * consider using dss-exec-lib actions where possible to avoid introducing interfaces * cleanup * restrict immutable visibility to addrs fetched from chainlog and use constant for literal addrs * move archive step together with spell deployment * address review comments + cleanups * update wordlist * improve archive checks * update deployed spell checklists * update deployment crafting checklists * update exec hash crafting checklists * update wordlist * update exec hash review checklists * indentation * add mom checklists * update readme * missing ) Co-authored-by: Chris Smith <[email protected]> * +patches bump notation Co-authored-by: Chris Smith <[email protected]> * address review comments * update wordlist * add lib checklists + improve dss-interfaces checks * cleanup * diff cleanups for review checklists * diff cleanups crafter checklists --------- Co-authored-by: Chris Smith <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.