Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanups & Refinements #10

Merged
merged 1 commit into from
Feb 14, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions spell/spell-crafter-goerli-workflow.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,6 @@ PR: https://github.com/makerdao/spells-goerli/pull/TODO
* [ ] Check previous spells in the `archive` folder for cleanup patterns
* [ ] Cleanup `src/test/config.sol`
* [ ] Set `deployed_spell` to `address(0)`
* [ ] Set `deployed_spell_created` to `0`
* [ ] Set `deployed_spell_block` to `0`
* [ ] Cleanup Specific Tests in `DssSpell.t.sol`
* [ ] Check previous spells in the `archive` folder for cleanup patterns
* [ ] Disable specific tests IF Not Used (e.g. `testCollateralIntegrations`, `testNewChainlogValues`, `testNewIlkRegistryValues`, ...)
Expand Down Expand Up @@ -118,11 +116,8 @@ PR: https://github.com/makerdao/spells-goerli/pull/TODO
* [ ] `seth chain`
* [ ] Deploy spell on Goerli via `make deploy`
* [ ] Ensure spell is verified on etherscan
* [ ] Add deployed spell address, timestamp and block number to `config.sol`
* [ ] Add deployed spell address to `config.sol`
* [ ] `deployed_spell: address(<deployed_spell_address>)`
* [ ] `deployed_spell_created: <timestamp>`
* [ ] `deployed_spell_block: <block number>`
* [ ] Run `make deploy-info tx=<tx_hash>` to get timestamp and block number
* [ ] Run Tests Locally with deployed spell address
* [ ] Commit & Push for Review
* [ ] Wait for CI to PASS
Expand Down
7 changes: 1 addition & 6 deletions spell/spell-crafter-mainnet-workflow.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,6 @@ Repo: https://github.com/makerdao/spells-mainnet
* [ ] Check previous spells in the `archive` folder for cleanup patterns
* [ ] Cleanup `src/test/config.sol`
* [ ] Set `deployed_spell` to `address(0)`
* [ ] Set `deployed_spell_created` to `0`
* [ ] Set `deployed_spell_block` to `0`
* [ ] Consider to add `previous_spell` address if it haven't been executed yet
* [ ] Cleanup Specific Tests in `DssSpell.t.sol`
* [ ] Check previous spells in the `archive` folder for cleanup patterns
Expand Down Expand Up @@ -128,11 +126,8 @@ Repo: https://github.com/makerdao/spells-mainnet
* [ ] `seth chain`
* [ ] Deploy spell on Goerli via `make deploy`
* [ ] Ensure spell is verified on etherscan
* [ ] Add deployed spell address, timestamp and block number to `config.sol`
* [ ] Add deployed spell address to `config.sol`
* [ ] `deployed_spell: address(<deployed_spell_address>)`
* [ ] `deployed_spell_created: <timestamp>`
* [ ] `deployed_spell_block: <block number>`
* [ ] Run `make deploy-info tx=<tx_hash>` to get timestamp and block number
* [ ] Run Tests Locally with deployed spell address
* [ ] Commit & Push for Review
* [ ] Wait for CI to PASS
Expand Down
4 changes: 0 additions & 4 deletions spell/spell-reviewer-goerli-checklist.md
Original file line number Diff line number Diff line change
Expand Up @@ -143,10 +143,6 @@ Spell Actions:
* [ ] Other Settings: default evmVersion, GNU AGPLv3 license
* [ ] Deployed Spell Code matches GitHub
* [ ] diffcheck etherscan source against spell PR (i.e. via vscode `code --diff etherscan.sol github.sol`)
* [ ] Deploy Timestamp & Block Number Match
* [ ] Ensure `make deploy-info tx=<tx>` matches [config](https://github.com/makerdao/spells-mainnet/blob/master/src/test/config.sol)
* [ ] `deployed_spell_created` timestamp
* [ ] `deployed_spell_block` block number
* [ ] Ensure Etherscan `Libraries Used` matches DssExecLib [Latest Release](https://github.com/makerdao/dss-exec-lib/releases/latest)
* [ ] git submodule hash matches [dss-exec-lib](https://github.com/makerdao/dss-exec-lib) latest release's tag commit
* [ ] Local Tests and CI PASS
Expand Down
4 changes: 0 additions & 4 deletions spell/spell-reviewer-mainnet-checklist.md
Original file line number Diff line number Diff line change
Expand Up @@ -147,10 +147,6 @@ Spell Actions:
* [ ] Other Settings: default evmVersion, GNU AGPLv3 license
* [ ] Deployed Spell Code matches GitHub
* [ ] diffcheck etherscan source against spell PR (i.e. via vscode `code --diff etherscan.sol github.sol`)
* [ ] Deploy Timestamp & Block Number Match
* [ ] Ensure `make deploy-info tx=<tx>` matches [config](https://github.com/makerdao/spells-mainnet/blob/master/src/test/config.sol)
* [ ] `deployed_spell_created` timestamp
* [ ] `deployed_spell_block` block number
* [ ] Ensure Etherscan `Libraries Used` matches DssExecLib [Latest Release](https://github.com/makerdao/dss-exec-lib/releases/latest)
* [ ] git submodule hash matches [dss-exec-lib](https://github.com/makerdao/dss-exec-lib) latest release's tag commit
* [ ] Local Tests and CI PASS
Expand Down