Revert "Cleanups & Refinements (#10)"

This reverts commit 4bdc4fa.
makerdao · Mar 6, 2023 · 9451ad2 · 9451ad2
1 parent 4bdc4fa
commit 9451ad2
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 2 deletions.
diff --git a/spell/spell-crafter-goerli-workflow.md b/spell/spell-crafter-goerli-workflow.md
@@ -17,6 +17,8 @@ PR: https://github.com/makerdao/spells-goerli/pull/TODO
   * [ ] Check previous spells in the `archive` folder for cleanup patterns
 * [ ] Cleanup `src/test/config.sol` 
   * [ ] Set `deployed_spell` to `address(0)`
+  * [ ] Set `deployed_spell_created` to `0`
+  * [ ] Set `deployed_spell_block` to `0`
 * [ ] Cleanup Specific Tests in `DssSpell.t.sol`
   * [ ] Check previous spells in the `archive` folder for cleanup patterns
   * [ ] Disable specific tests IF Not Used (e.g. `testCollateralIntegrations`, `testNewChainlogValues`, `testNewIlkRegistryValues`, ...)
@@ -116,8 +118,11 @@ PR: https://github.com/makerdao/spells-goerli/pull/TODO
     * [ ] `seth chain`
 * [ ] Deploy spell on Goerli via `make deploy`
   * [ ] Ensure spell is verified on etherscan
-* [ ] Add deployed spell address to `config.sol`
+* [ ] Add deployed spell address, timestamp and block number to `config.sol`
   * [ ] `deployed_spell: address(<deployed_spell_address>)`
+  * [ ] `deployed_spell_created: <timestamp>`
+  * [ ] `deployed_spell_block: <block number>`
+    * [ ] Run `make deploy-info tx=<tx_hash>` to get timestamp and block number
 * [ ] Run Tests Locally with deployed spell address
 * [ ] Commit & Push for Review
 * [ ] Wait for CI to PASS

diff --git a/spell/spell-crafter-mainnet-workflow.md b/spell/spell-crafter-mainnet-workflow.md
@@ -17,6 +17,8 @@ Repo: https://github.com/makerdao/spells-mainnet
   * [ ] Check previous spells in the `archive` folder for cleanup patterns
 * [ ] Cleanup `src/test/config.sol`
   * [ ] Set `deployed_spell` to `address(0)`
+  * [ ] Set `deployed_spell_created` to `0`
+  * [ ] Set `deployed_spell_block` to `0`
   * [ ] Consider to add `previous_spell` address if it haven't been executed yet
 * [ ] Cleanup Specific Tests in `DssSpell.t.sol`
   * [ ] Check previous spells in the `archive` folder for cleanup patterns
@@ -126,8 +128,11 @@ Repo: https://github.com/makerdao/spells-mainnet
     * [ ] `seth chain`
 * [ ] Deploy spell on Goerli via `make deploy`
   * [ ] Ensure spell is verified on etherscan
-* [ ] Add deployed spell address to `config.sol`
+* [ ] Add deployed spell address, timestamp and block number to `config.sol`
   * [ ] `deployed_spell: address(<deployed_spell_address>)`
+  * [ ] `deployed_spell_created: <timestamp>`
+  * [ ] `deployed_spell_block: <block number>`
+    * [ ] Run `make deploy-info tx=<tx_hash>` to get timestamp and block number
 * [ ] Run Tests Locally with deployed spell address
 * [ ] Commit & Push for Review
 * [ ] Wait for CI to PASS

diff --git a/spell/spell-reviewer-goerli-checklist.md b/spell/spell-reviewer-goerli-checklist.md
@@ -143,6 +143,10 @@ Spell Actions:
   * [ ] Other Settings: default evmVersion, GNU AGPLv3 license
 * [ ] Deployed Spell Code matches GitHub
   * [ ] diffcheck etherscan source against spell PR (i.e. via vscode `code --diff etherscan.sol github.sol`)
+* [ ] Deploy Timestamp & Block Number Match
+  * [ ] Ensure `make deploy-info tx=<tx>` matches [config](https://github.com/makerdao/spells-mainnet/blob/master/src/test/config.sol)
+    * [ ] `deployed_spell_created` timestamp
+    * [ ] `deployed_spell_block` block number
 * [ ] Ensure Etherscan `Libraries Used` matches DssExecLib [Latest Release](https://github.com/makerdao/dss-exec-lib/releases/latest)
   * [ ] git submodule hash matches [dss-exec-lib](https://github.com/makerdao/dss-exec-lib) latest release's tag commit
 * [ ] Local Tests and CI PASS

diff --git a/spell/spell-reviewer-mainnet-checklist.md b/spell/spell-reviewer-mainnet-checklist.md
@@ -147,6 +147,10 @@ Spell Actions:
   * [ ] Other Settings: default evmVersion, GNU AGPLv3 license
 * [ ] Deployed Spell Code matches GitHub
   * [ ] diffcheck etherscan source against spell PR (i.e. via vscode `code --diff etherscan.sol github.sol`)
+* [ ] Deploy Timestamp & Block Number Match
+  * [ ] Ensure `make deploy-info tx=<tx>` matches [config](https://github.com/makerdao/spells-mainnet/blob/master/src/test/config.sol)
+    * [ ] `deployed_spell_created` timestamp
+    * [ ] `deployed_spell_block` block number
 * [ ] Ensure Etherscan `Libraries Used` matches DssExecLib [Latest Release](https://github.com/makerdao/dss-exec-lib/releases/latest)
   * [ ] git submodule hash matches [dss-exec-lib](https://github.com/makerdao/dss-exec-lib) latest release's tag commit
 * [ ] Local Tests and CI PASS