Destructuring of Ember.testing will not work.

[rwjblue]

Just happened to notice this:

https://github.com/simplabs/ember-simple-auth/blob/c295fee9b0bab6fdf7dcfca0cb706b68415caa95/addon/mixins/application-route-mixin.js#L10

Which is used here:

https://github.com/simplabs/ember-simple-auth/blob/c295fee9b0bab6fdf7dcfca0cb706b68415caa95/addon/mixins/application-route-mixin.js#L141-L149

Ember.testing is a getter/setter in Ember, and destructuring like this will only read its value at the time the module is evaluated. In this case, Ember.testing will most likely be false when the module is evaluated, then change to true during the test. This behavior somewhat recently changed in emberjs/ember-test-helpers#227 (which is included in [email protected] / [email protected]).

I believe the fix here would be to remove the destructuring, and use Ember.testing directly inline.

[rwjblue]

Found another destructuring (via GH search):

https://github.com/simplabs/ember-simple-auth/blob/c295fee9b0bab6fdf7dcfca0cb706b68415caa95/addon/session-stores/cookie.js#L13

Which is used:

https://github.com/simplabs/ember-simple-auth/blob/c295fee9b0bab6fdf7dcfca0cb706b68415caa95/addon/session-stores/cookie.js#L250-L260

and

https://github.com/simplabs/ember-simple-auth/blob/c295fee9b0bab6fdf7dcfca0cb706b68415caa95/addon/session-stores/cookie.js#L273-L283

[rwjblue]

FYI - This is likely to bite folks updating to the latest ember-cli-qunit version (4.1.1)...

[marcoow]

Thanks for the notice!

[Turbo87]

FWIW this will also be an issue for the next release of ember-cli-mocha. We should probably release this soon :)