don't destructure Ember.testing #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Module destructures are evaluated at build time, but this value is changed dynamically at runtime. Avoiding the destructure is the only way to work given this behavior. See these issues: mainmatter/ember-simple-auth#1476 emberjs/ember-test-helpers#227
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Module destructures are evaluated at build time, but this value is changed dynamically at runtime. Avoiding the destructure is the only way to work given this behavior. See these issues:
mainmatter/ember-simple-auth#1476
emberjs/ember-test-helpers#227
I have confirmed that this fixes the acceptance test failures I was encountering after upgrading to Ember v2.17, where
andThen()did not appear to be waiting for ember-apollo-client's promises to resolve.Resolves #76. Thanks @rwjblue.