Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't destructure Ember.testing #45

Closed
bgentry opened this issue Jun 10, 2018 · 0 comments · Fixed by #46
Closed

Don't destructure Ember.testing #45

bgentry opened this issue Jun 10, 2018 · 0 comments · Fixed by #46

Comments

@bgentry
Copy link
Contributor

bgentry commented Jun 10, 2018

As discussed in this issue and many others, Ember.testing is not reliable at runtime if it is destructured: mainmatter/ember-simple-auth#1476

This addon probably needs to call Ember.testing directly for it to be reliable.
bgentry added a commit to bgentry/ember-cli-new-version that referenced this issue Jun 10, 2018
@bgentry
don't destructure Ember.testing
afbb1c0 
Fixes sethwebster#45.
@bgentry bgentry mentioned this issue Jun 10, 2018
Merged
knownasilya pushed a commit that referenced this issue Jun 11, 2018
@bgentry @knownasilya
fix: Don't destructure Ember.testing (#46)
8f59e4a 
* don't destructure Ember.testing

Fixes #45.

* fix setResolver import deprecation

* longer timer in test to fix flakiness
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't destructure Ember.testing bgentry/ember-cli-new-version
1 participant
@bgentry