Service Worker route handling refactor #1859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… is not mentioned. Weird.
Co-Authored-By: Andy Terranova <[email protected]>
…gento/pwa-studio into revanth/serviceWorkerRefactor
revanth0212
added
the
version: Minor
|
Do not worry about the number of changes, that is because this PR is based on changes that are yet to be merged as part of #1832 |
|
|
|
||
| workbox.routing.registerRoute( | ||
| new RegExp('/.\\.js$'), | ||
| new RegExp('(robots.txt|favicon.ico|manifest.json)'), |
There was a problem hiding this comment.
Quick regex gotcha: that . actually matches on any character. If you want the literal ., it needs to be escaped: \..
Doesn't prevent a 👍 , just an fyi :)
supernova-at
approved these changes
Oct 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR rearranges Service Worker routes to match that of UPWARD. For now, it does not produce any significant changes but this needed to fix other issues. Also, this adds a new route that matches
robots.txt,manifest.jsonandfavicon.ico. So you should be seeing them being served from the service worker expect for the first time. The service worker uses the stale while revalidate strategy to serve these files, meaning it will return what it has immediately to the UI and then fetches the files in the background and updates them in the cache for later use.Related Issue
Closes #1857
Verification Steps
favicon should be cached on the client. This should be verifiable by looking at the network tab or the caches tab in chrome dev tools.
It is not working as of now in
stagemode and a bug has been logged #1861.Checklist
Just a casual sanity check should be enough.