Service Worker HTML Handling #1874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… is not mentioned. Weird.
Co-Authored-By: Andy Terranova <[email protected]>
…gento/pwa-studio into revanth/serviceWorkerRefactor
revanth0212
added
pkg:venia-concept
version: Minor
supernova-at
requested changes
Oct 15, 2019
packages/venia-concept/src/ServiceWorker/Utilities/routeHandler.js
Outdated
Show resolved
Hide resolved
m2-community-project
bot
added
Progress: changes requested
and removed
Progress: review
labels
m2-community-project
bot
added
Progress: review
and removed
Progress: changes requested
labels
supernova-at
previously approved these changes
Oct 16, 2019
supernova-at
approved these changes
Oct 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Modified the HTML handling capabilities of the Service Worker to fetch and return the same HTML file irrespective of the page the client is in. This is because HTML for
/is the samevenia-bottoms.htmlorathena-tank-dress.html. Also since the same HTML is served for all the routes, offline capabilities are improved compared todevelopas demonstrated in the demo gif.Related Issue
Closes #1781
Verification Steps
yarn build && yarn stage:venia./unlinedevelopin which each page will request its own HTML file.Screenshots / Screen Captures (if appropriate)
Checklist
venia:stage and venia:watchshould both work asdevelop. No business logic changed.