Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug]: favicon not loading in stage mode. #1861

Closed
3 of 8 tasks
revanth0212 opened this issue Oct 7, 2019 · 1 comment
Closed
3 of 8 tasks

[bug]: favicon not loading in stage mode. #1861

revanth0212 opened this issue Oct 7, 2019 · 1 comment
Labels
bug Something isn't working

Comments

@revanth0212
Copy link
Contributor

Describe the bug
Venia favicon is not loading in the stage mode. Works fine in watch mode.

To reproduce
Steps to reproduce the behavior:

  1. Run yarn build && yarn stage:venia.
  2. Go to the URL mentioned in the terminal.
  3. No favicon should be loaded even though the service responsed with 200.

Expected behavior
favicon should show up in the tab just like in watch mode.

Screenshots
image

image

Please complete the following device information:

  • Device [e.g. iPhone6, PC, Mac, Pixel3]: MacBookPro
  • OS [e.g. iOS8.1, Windows 10]: Mac OS Sierra
  • Browser [e.g. Chrome, Safari]: Chrome

Please let us know what packages this bug is in regards to:

  • venia-concept
  • venia-ui
  • pwa-buildpack
  • peregrine
  • pwa-devdocs
  • upward-js
  • upward-spec
  • create-pwa
@supernova-at
Copy link
Contributor

I noticed this on our deployments of the latest develop and release / master too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants