Handle empty or incorrect lines in a language CSV #12304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to2 into bugfix/language-pack-empty-line
- Updated test data to cover this case
magento-team
pushed a commit
that referenced
this pull request
Nov 18, 2017
magento-team
pushed a commit
that referenced
this pull request
Nov 18, 2017
[EngCom] Public Pull Requests - 2.2-develop - MAGETWO-84098: Webshop throws an exception when sharing wishlist with RSS enabled #12276 - MAGETWO-84081: 9684: No ACL set for integrations #12332 - MAGETWO-84006: Fix robots.txt content type to 'text/plain' #12310 - MAGETWO-83977: Handle empty or incorrect lines in a language CSV #12304
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reading language packs will break if the CSV file contains incorrect lines. For example an accidental empty line at the end of the file will cause an undefined index error.
Manual testing scenarios
Current 2.2 code will show errors. With this change it will skip over the incorrect line without error.
Contribution checklist