Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webshop throws an exception when sharing wishlist with RSS enabled #12276

Merged
merged 2 commits into from
Nov 18, 2017

Conversation

mediactbv
Copy link

Description

In this pull request a bug that was discovered while the "Share Wishlist" functionality was executed. When a logged in user adds products to the wishlist and then tries to share them using RSS, an exception is thrown: report.INFO: Broken reference: the 'wishlist.email.rss' element cannot be added as child to 'root', because the latter doesn't exist []

Manual testing scenarios

  1. Enable the RSS feed from wishlist in the backend
  2. Open the front-end of a magento 2 installation.
  3. Log in a user on the frontend
  4. Add one or more products to the wishlist
  5. Go to My Account -> My wishlist
  6. Click on the "Share wishlist" button
  7. Ensure the RSS feed checkbox is checked
  8. Click on Share wishlist

This is reproduced on Feestwinken and Grasscity so for sure on M2:2.1.9

Firstly, login to your admin area and navigate to Stores> Configuration. Then click to expand Catalog tab and select RSS Feeds. Then enable ths RSS feeds for Wishlist. After that follow the steps:

1. Open the front-end of a magneto 2 installation.
2. Login
3. Add multiple product to wish list
4. Go to My Account> My wish list
5. Ckeck on "Share wish list"
6. Choose to use RSS feed in Checkbox and submit Share Wish List
@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Nov 15, 2017

CLA assistant check
All committers have signed the CLA.

@mediactbv mediactbv changed the title 2.2 mediact develop Webshop throws an exception when sharing wishlist with RSS enabled Nov 15, 2017
@ishakhsuvarov
Copy link
Contributor

Hi @mediactbv
Please sign the CLA with the email you used for the commit, so that we can proceed with the review and merge.
Thank you

@ishakhsuvarov ishakhsuvarov self-assigned this Nov 17, 2017
@ishakhsuvarov ishakhsuvarov added this to the November 2017 milestone Nov 17, 2017
@magento-team magento-team merged commit 9f8c7d1 into magento:2.2-develop Nov 18, 2017
magento-team pushed a commit that referenced this pull request Nov 18, 2017
[EngCom] Public Pull Requests - 2.2-develop
 - MAGETWO-84098: Webshop throws an exception when sharing wishlist with RSS enabled #12276
 - MAGETWO-84081: 9684: No ACL set for integrations #12332
 - MAGETWO-84006: Fix robots.txt content type to 'text/plain' #12310
 - MAGETWO-83977: Handle empty or incorrect lines in a language CSV #12304
@jasperzeinstra jasperzeinstra deleted the 2.2-mediact-develop branch November 20, 2018 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants