-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport] Handle empty or incorrect lines in a language CSV #15287
[Backport] Handle empty or incorrect lines in a language CSV #15287
Conversation
The original PR seems to have one extra newline in the csv file. Or is it just github's rendering that is confusing? |
This is the line ending. |
@hostep you are right, probably different EOL settings or just forgotten? Should be probably added here too as files should end with an empty line normally (this is alo what VSCode automatically does). |
I actually think there are two empty lines, since github doesn't render the last empty line, hence why they use that symbol for indicating there is no empty line at the end. So in this case, there is no symbol and we see an empty line, so I assume there are 2 empty lines. @VitaliyBoyko: it's probably best if you can exactly copy that file from the original PR including the exact same number of empty lines, thanks! |
Added one more empty line
Hi @VitaliyBoyko. Thank you for your contribution. |
Original PR: #12304
Description:
Reading language packs will break if the CSV file contains incorrect lines. For example an accidental empty line at the end of the file will cause an undefined index error.