Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stop displaying empty descriptions #346

Merged
merged 2 commits into from
Mar 28, 2022

Conversation

olga-union
Copy link
Contributor

@olga-union olga-union commented Mar 25, 2022

Signed-off-by: Olga Nad [email protected]

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

Workflow and task descriptions aren't properly populating due to issues on the backend, while they are being addressed, empty description string should not be rendered.

Demo

Workflows
Screen Shot 2022-03-25 at 9 56 39 AM
Tasks
Screen Shot 2022-03-25 at 9 56 52 AM

@codecov
Copy link

codecov bot commented Mar 25, 2022

Codecov Report

Merging #346 (d971875) into master (2f25ecd) will decrease coverage by 0.01%.
The diff coverage is 16.66%.

@@            Coverage Diff             @@
##           master     #346      +/-   ##
==========================================
- Coverage   65.24%   65.23%   -0.02%     
==========================================
  Files         391      391              
  Lines        8722     8724       +2     
  Branches     1507     1510       +3     
==========================================
  Hits         5691     5691              
- Misses       3031     3033       +2     
Impacted Files Coverage Δ
src/common/constants.ts 100.00% <ø> (ø)
src/components/Task/SearchableTaskNameList.tsx 0.00% <0.00%> (ø)
...components/Workflow/SearchableWorkflowNameList.tsx 59.37% <33.33%> (-0.31%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f25ecd...d971875. Read the comment docs.

anrusina
anrusina previously approved these changes Mar 25, 2022
Copy link
Contributor

@anrusina anrusina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with small comment

Copy link
Contributor

@anrusina anrusina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@jsonporter
Copy link
Contributor

lgtm

@flyte-bot
Copy link
Collaborator

🎉 This PR is included in version 0.47.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants