Skip to content

Commit

Permalink
chore: update nodejs version to latest LTS 16 #patch (#345)
Browse files Browse the repository at this point in the history
  • Loading branch information
anrusina authored Mar 25, 2022
1 parent 481034a commit 2f25ecd
Show file tree
Hide file tree
Showing 7 changed files with 12 additions and 11 deletions.
3 changes: 2 additions & 1 deletion .eslintignore
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
src/generated/
.github/
.dist/
dist/
node_modules/
tsd/
webpack.config.ts
webpack.config.ts
10 changes: 5 additions & 5 deletions .github/workflows/checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
fetch-depth: 0
- uses: actions/setup-node@v2
with:
node-version: '12'
node-version: 16
- uses: bahmutov/npm-install@v1
- name: Run tests and generate coverage
run: make test_unit_codecov
Expand All @@ -34,7 +34,7 @@ jobs:
- uses: actions/checkout@v2
- uses: actions/setup-node@v2
with:
node-version: '12'
node-version: 16
- uses: bahmutov/npm-install@v1
- name: Run linter
run: make lint
Expand All @@ -54,15 +54,15 @@ jobs:
release:
name: Generate Release
if: ${{ github.event_name != 'pull_request' }}
needs: [ unit_tests_with_coverage, lint_project, build_docker_image ]
needs: [unit_tests_with_coverage, lint_project, build_docker_image]
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v2
- name: Setup Node.js
uses: actions/setup-node@v1
with:
node-version: 12
node-version: 16
- name: Install dependencies
run: yarn install --frozen-lockfile
- name: Release
Expand Down Expand Up @@ -99,7 +99,7 @@ jobs:
push_docker_image:
name: Build & Push Flyteconsole Image
needs: [ check_for_tag ]
needs: [check_for_tag]
uses: flyteorg/flytetools/.github/workflows/publish.yml@master
with:
version: ${{ needs.check_for_tag.outputs.currentTag }}
Expand Down
2 changes: 1 addition & 1 deletion .tool-versions
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
nodejs 14.18.3
nodejs 16.14.2
yarn 1.22.17
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM node:14 as builder
FROM node:16 as builder
LABEL org.opencontainers.image.source https://github.com/lyft/flyteconsole

WORKDIR /code/flyteconsole
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@
"@types/memoize-one": "^4.1.0",
"@types/memory-fs": "^0.3.0",
"@types/moment-timezone": "^0.5.13",
"@types/node": "^14.14.31",
"@types/node": "^14.18.12",
"@types/object-hash": "^1.2.0",
"@types/pure-render-decorator": "^0.2.27",
"@types/react": "^16.9.34",
Expand Down
2 changes: 1 addition & 1 deletion tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"experimentalDecorators": true,
"importHelpers": true,
"jsx": "react",
"lib": ["es2015", "es2017", "es2019", "dom", "dom.iterable"],
"lib": ["es6", "es2021", "dom", "dom.iterable"],
"module": "commonjs",
"moduleResolution": "node",
"noFallthroughCasesInSwitch": true,
Expand Down
2 changes: 1 addition & 1 deletion yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -4379,7 +4379,7 @@
resolved "https://registry.yarnpkg.com/@types/node/-/node-10.17.48.tgz#726e7f25d00bf58d79c8f00dd586dd9a10d06a4f"
integrity sha512-Agl6xbYP6FOMDeAsr3QVZ+g7Yzg0uhPHWx0j5g4LFdUBHVtqtU+gH660k/lCEe506jJLOGbEzsnqPDTZGJQLag==

"@types/node@^14.0.10", "@types/node@^14.14.31":
"@types/node@^14.0.10", "@types/node@^14.18.12":
version "14.18.12"
resolved "https://registry.yarnpkg.com/@types/node/-/node-14.18.12.tgz#0d4557fd3b94497d793efd4e7d92df2f83b4ef24"
integrity sha512-q4jlIR71hUpWTnGhXWcakgkZeHa3CCjcQcnuzU8M891BAWA2jHiziiWEPEkdS5pFsz7H9HJiy8BrK7tBRNrY7A==
Expand Down

0 comments on commit 2f25ecd

Please sign in to comment.