fix: stop displaying empty descriptions (#346)

* fix: stop displaying empty descriptions * fix: remove unused const Signed-off-by: Olga Nad <[email protected]>
flyteorg · Mar 28, 2022 · 6a964f6 · 6a964f6
1 parent 831d738
commit 6a964f6
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 9 deletions.
diff --git a/src/common/constants.ts b/src/common/constants.ts
@@ -4,7 +4,6 @@ export const navBarContentId = 'nav-bar-content';
 
 export const unknownValueString = '(unknown)';
 export const dashedValueString = '----';
-export const noDescriptionString = '(No description)';
 export const noneString = '(none)';
 export const noExecutionsFoundString = 'No executions found.';
 export const noWorkflowVersionsFoundString = 'No workflow versions found.';

diff --git a/src/components/Task/SearchableTaskNameList.tsx b/src/components/Task/SearchableTaskNameList.tsx
@@ -3,7 +3,6 @@ import { makeStyles, Theme } from '@material-ui/core/styles';
 import ChevronRight from '@material-ui/icons/ChevronRight';
 import ErrorOutline from '@material-ui/icons/ErrorOutline';
 import classnames from 'classnames';
-import { noDescriptionString } from 'common/constants';
 import { SearchResult } from 'components/common/SearchableList';
 import {
   SearchableNamedEntity,
@@ -79,15 +78,17 @@ const TaskNameRow: React.FC<TaskNameRowProps> = ({ label, entityName }) => {
   const styles = useStyles();
   const listStyles = useNamedEntityListStyles();
   const [inViewRef, inView] = useInView(intersectionOptions);
-  const description = entityName.metadata.description || noDescriptionString;
+  const description = entityName?.metadata?.description;
 
   return (
     <div ref={inViewRef} className={listStyles.searchResult}>
       <div className={listStyles.itemName}>
         <div className={styles.taskName}>{label}</div>
-        <Typography variant="body2" className={styles.description}>
-          {description}
-        </Typography>
+        {description && (
+          <Typography variant="body2" className={styles.description}>
+            {description}
+          </Typography>
+        )}
         {!!inView && <TaskInterface taskName={entityName} />}
       </div>
       <ChevronRight className={listStyles.itemChevron} />

diff --git a/src/components/Workflow/SearchableWorkflowNameList.tsx b/src/components/Workflow/SearchableWorkflowNameList.tsx
@@ -11,6 +11,7 @@ import { WorkflowExecutionPhase } from 'models/Execution/enums';
 import { Shimmer } from 'components/common/Shimmer';
 import { WorkflowExecutionIdentifier } from 'models/Execution/types';
 import { debounce } from 'lodash';
+import { Typography } from '@material-ui/core';
 import { WorkflowListStructureItem } from './types';
 import ProjectStatusBar from '../Project/ProjectStatusBar';
 import { workflowNoInputsString } from '../Launch/LaunchForm/constants';
@@ -120,9 +121,11 @@ const SearchableWorkflowNameItem: React.FC<SearchableWorkflowNameItemProps> = Re
             <DeviceHub className={styles.itemIcon} />
             <div>{id.name}</div>
           </div>
-          <div className={styles.itemDescriptionRow}>
-            {description?.length ? description : 'This workflow has no description.'}
-          </div>
+          {description && (
+            <Typography variant="body2" className={styles.itemDescriptionRow}>
+              {description}
+            </Typography>
+          )}
           <div className={styles.itemRow}>
             <div className={styles.itemLabel}>Last execution time</div>
             <div className={styles.w100}>