Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AltTab should intercept command+shift+tab if command+tab is bound #2080

Closed
Swandog opened this issue Nov 4, 2022 · 7 comments
Closed

AltTab should intercept command+shift+tab if command+tab is bound #2080

Swandog opened this issue Nov 4, 2022 · 7 comments
Labels
enhancement New feature or request

Comments

@Swandog
Copy link

Swandog commented Nov 4, 2022

Describe the bug

I have Alt-Tab configured with Command+Tab as the shortcut. This works great, and has been for some time. With the latest release, though, there seems to be a problem with using Command+Shift+Tab to cycle backwards through windows. When I hit Command+Shift+Tab, it does cycle windows in Alt-Tab; but it also raises the default MacOS application switcher as well. Then I have to close/escape out of that one after I've finished selecting a window in Alt-Tab.

I'm pretty sure this issue wasn't happening in the version prior to this one.

Screenshots / video

Screen Shot 2022-11-04 at 10 25 34 AM

Steps to reproduce the bug

  1. Set up Alt-Tab with a shortcut of "Hold ⌘" and press "⇥" (this is what comes up for Command-Tab for me)
  2. Use Command-Tab to bring up the Alt-Tab switcher
  3. Use Command-Shift-Tab to cycle backwards in Alt-Tab

Notes: I tried resetting my preferences, that did not help. Command+Tab does not bring up the default switcher; only Command+Shift+Tab does.

@Swandog Swandog added the bug Something isn't working label Nov 4, 2022
@lwouis
Copy link
Owner

lwouis commented Nov 4, 2022

Hi @Swandog,

I just tried to reproduce but couldn't. I tried with these preferences:

image

Could you please share your preferences?

@lwouis lwouis added the unreproducible Need help from the author to reproduce the issue label Nov 4, 2022
@adityakaulagi
Copy link

adityakaulagi commented Nov 4, 2022

@Swandog I was able to reproduce the bug you mentioned. I think you're experiencing this because AltTab has a different approach to shortcut compared to the native app switcher for going to previous window/app (tested on macOS 12.6.1).

  1. In the native app switcher, cmd+tab is used to bring up the app switcher. To select the next app, you press tab while holding cmd. To select the previous app, you press tab while holding cmd and shift.

  2. For AltTab, the shortcut you've assigned will bring up AltTab's app switcher. Let's assume this is cmd+tab. Then, to select next window, you need to hold cmd and press tab. To go to previous window, you should hold cmd and press shift, which is different than holding both cmd and shift and pressing tab that you do for native app switcher.

So by holding cmd+shift and pressing tab, you're bringing up the native app switcher.

Personally, I prefer AltTab's approach since I have to press only 2 keys to go to previous window.

@lwouis
Copy link
Owner

lwouis commented Nov 4, 2022

Oh, I see.

I thought I should only disable the native command+shift+tab if the exact shortcut is bound in AltTab, but I guess it's confusing that command+tab would be disabled (replaced with AltTab) but command+shift+tab not be.

I think I'll add a special case that if command+tab is bound, then both native command+tab and command+shift+tab should be disabled. I think it will help for most people. It will still not work if people press command+shift+tab as the tab key will go forward and the shift key will go backward, so depending on the order they are pressed it will mess up in a different way. But that can't be helped. People hopefully learn that it's only shift that's use to cycle backwards.

@lwouis lwouis added enhancement New feature or request and removed bug Something isn't working unreproducible Need help from the author to reproduce the issue labels Nov 6, 2022
@lwouis lwouis changed the title Latest version not intercepting Command-Shift-Tab AltTab should intercept command+shift+tab if command+tab is bound Nov 6, 2022
@Swandog
Copy link
Author

Swandog commented Nov 7, 2022

Ah yes--this is exactly the case! Somehow I didn't trigger this before. But now, testing it out, I see that command+shift works exactly as described by @lwouis and @adityakaulagi . I was used to the default switcher's command keys, and that was what was tripping me up.

Now that I know how it works, I can figure it out. Though it would still be helpful to me if command+shift+tab was disabled.

Thanks!

This was referenced Nov 9, 2022
@puntium
Copy link

puntium commented Nov 11, 2022

Came here to chime in on the same issue. My muscle memory from 20 years using windows causes me to hit "cmd + shift + tab" after i've already summoned the alt-tab switcher with a cmd-tab shortcut. This causes the native app switcther to appear in addition to the alt-tab window switcher which is very confusing.

repro steps:

  1. create a command + tab short cut in AltTab
  2. hit AltTab to bring up window switcher
  3. without letting go of command, also press shift + tab
  4. see now native app switcher appear on top of AltTab switcher

expected behavior: Shift+tab would cause a previous item in the AltTab switcher to be selected.

@lwouis
Copy link
Owner

lwouis commented Nov 12, 2022

Next release will have the mitigation to avoid this issue

@lwouis lwouis closed this as completed in f906c0e Nov 14, 2022
lwouis pushed a commit that referenced this issue Nov 14, 2022
# [6.50.0](v6.49.0...v6.50.0) (2022-11-14)

### Bug Fixes

* don't show firefox tooltips as windows (closes [#2110](#2110)) ([bf905b1](bf905b1))
* tabs show as separate windows sometimes on monterey (closes [#2017](#2017)) ([0965a78](0965a78))

### Features

* avoid accidental press of the "reset preferences" button ([#2093](#2093)) ([f6fcac5](f6fcac5))
* avoid confusion with native app-switcher (closes [#2080](#2080)) ([f906c0e](f906c0e))
* improve localizations ([2123af3](2123af3))
* show alttab on display with active menubar when needed ([#2107](#2107)) ([917e661](917e661))
@Swandog
Copy link
Author

Swandog commented Nov 28, 2022

FWIW--I got the update today and it fixes the issue perfectly! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants