Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make "Reset preferences and restart" button less likely to be pressed by accident #2093

Closed
olehmisar opened this issue Nov 8, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@olehmisar
Copy link

Is your feature suggestion related to a problem? Please describe.
I just pressed Reset preferences and restart button by accident. Now, all my settings are gone 😭 .

Describe the solution you'd like
That's a very "dangerous" button! Add a confirmation dialog when pressing it. And maybe move it somewhere else, where it is less likely to be pressed by accident(as I just did).

Describe alternatives you've considered
-

image

@olehmisar olehmisar added the enhancement New feature or request label Nov 8, 2022
@lwouis
Copy link
Owner

lwouis commented Nov 8, 2022

We already mark this button with hasDestructiveAction which is supposed to have the OS (from macOS 11 onwards) do special things about it. I think it makes it so the user can't activate the button by pressing return. It doesn't make the button red though, as is seen in some docs.

I may be able to force the button to be red (on recent version of macOS only), but that may not be a good idea according to this discussion:

It would appear at first glance that painting the close box red is a good thing, since that warns the user about its potential danger. However, a study done at Apple almost ten years ago found that the user's mouse gravitates toward red objects almost as though they were possessed with magnetism. The study forced us to abandon the idea of making close boxes and the Shut Down option red.

I think adding a confirmation dialog would be nice.

@jiho4
Copy link

jiho4 commented Nov 11, 2022

I had the same experience 😂
Adding a confirmation dialog would be the best and most effective way to solve this problem.

@lwouis lwouis closed this as completed in f6fcac5 Nov 14, 2022
lwouis pushed a commit that referenced this issue Nov 14, 2022
# [6.50.0](v6.49.0...v6.50.0) (2022-11-14)

### Bug Fixes

* don't show firefox tooltips as windows (closes [#2110](#2110)) ([bf905b1](bf905b1))
* tabs show as separate windows sometimes on monterey (closes [#2017](#2017)) ([0965a78](0965a78))

### Features

* avoid accidental press of the "reset preferences" button ([#2093](#2093)) ([f6fcac5](f6fcac5))
* avoid confusion with native app-switcher (closes [#2080](#2080)) ([f906c0e](f906c0e))
* improve localizations ([2123af3](2123af3))
* show alttab on display with active menubar when needed ([#2107](#2107)) ([917e661](917e661))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants