Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds various badge icons, rebases verified as badge-check #1118

Merged
merged 8 commits into from
May 17, 2023

Conversation

karsa-mistmere
Copy link
Member

@karsa-mistmere karsa-mistmere commented Apr 19, 2023

closes #1109 #1073

Addresses some leftover comments from #416 and renames verified to be badge-check while also adding its base shape.

Also makes the shape more consistent in size with circle.

Also adds feathericons/feather#865 as part of #119

@github-actions
Copy link

github-actions bot commented Apr 19, 2023

Added or changed icons

Icon X-rays icons/badge-alert.svg icons/badge-check.svg icons/badge-dollar-sign.svg icons/badge-help.svg icons/badge-info.svg icons/badge-minus.svg icons/badge-percent.svg icons/badge-plus.svg icons/badge-x.svg icons/badge.svg icons/circle-dollar-sign.svg

icons/badge-dollar-sign.svg Outdated Show resolved Hide resolved
icons/badge-help.svg Outdated Show resolved Hide resolved
icons/badge-info.svg Outdated Show resolved Hide resolved
icons/badge-minus.svg Outdated Show resolved Hide resolved
icons/badge-minus.svg Show resolved Hide resolved
icons/badge-percent.svg Outdated Show resolved Hide resolved
icons/badge-plus.svg Show resolved Hide resolved
icons/badge-x.svg Show resolved Hide resolved
icons/circle-dollar-sign.svg Outdated Show resolved Hide resolved
@karsa-mistmere karsa-mistmere mentioned this pull request Apr 19, 2023
9 tasks
Copy link
Member

@ericfennis ericfennis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm I'm not sure with increasing the size of the badge outline.
I think it breaks a bit the balance in the icons
I placed side by side with twitter icon, and I think the original verified in lucide. looks way better.
image

@karsa-mistmere
Copy link
Member Author

@ericfennis: well, in comparison to Twitter maybe, but in comparison to our own circle-check icon, I think it's the other way around (this was the trigger of this PR in the first place):

image

@danielbayley
Copy link
Member

in comparison to our own circle-check icon

I think the circle is too big in that instance 😅

@karsa-mistmere
Copy link
Member Author

karsa-mistmere commented Apr 25, 2023

@jguddas: well, circle and square are our baselines for all other icons. :D

If anything, the checkmark may be too small, compared to FA the proposed new base shape is much more in line (top FA, bottom PR):
image

@danielbayley
Copy link
Member

@jguddas: well, circle and square are our baselines for all other icons. :D

(me 😅)

I get that… But I think the crux of it is that circle is bigger (20x20px) than square (18x18px)…

@karsa-mistmere
Copy link
Member Author

I get that… But I think the crux of it is that circle is bigger (20x20px) than square (18x18px)…

Well, that's the exactly the point. Squares have a smaller visual weight than circles. 🙂

@jguddas
Copy link
Member

jguddas commented Apr 25, 2023

If anything than it's the square that's to big. π*10px^2 = 314px vs 18x18px = 324px

@danielbayley
Copy link
Member

Squares have a smaller visual weight than circles

Sure, but I mean in terms of trying to fit the same elements nicely inside both is problematic :)

@karsa-mistmere
Copy link
Member Author

If anything than it's the square that's to big. 10px²×π = 314px² vs 18px×18px = 324px²

Oh, but you're forgetting the 2px rounding!😄
That will result in 320.56px², which is amazingly close considering we're bound to a 24 by 24 pixel grid.

@jguddas
Copy link
Member

jguddas commented Apr 25, 2023

Oh that's right 😄 @karsa-mistmere.

We are not super consistent when we look at the convex hull to compare visual weight.

image

https://observablehq.com/d/fdcccb6b2881ba87

@karsa-mistmere
Copy link
Member Author

@jguddas: Yeah definitely have some outliers, but we should certainly strive for consistency. :)

Also, convex hull is a nice metric, but not necessarily the best measure of visual weight, see the article above.

@karsa-mistmere karsa-mistmere merged commit 3fc3122 into lucide-icons:main May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants