-
-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add verified icon #416
Add verified icon #416
Conversation
@siarie Awesome icon! Thanks for this contribution! |
icons/verified.svg
Outdated
stroke-linecap="round" | ||
stroke-linejoin="round" | ||
> | ||
<path d="M11.997 3a3.599 3.599 0 00-3.044 1.682 3.599 3.599 0 00-.908-.095 3.599 3.599 0 00-2.411 1.051 3.6 3.6 0 00-.947 3.318A3.6 3.6 0 003 12.004a3.6 3.6 0 001.69 3.047 3.6 3.6 0 00.947 3.315 3.599 3.599 0 003.352.96A3.599 3.599 0 0012.002 21a3.599 3.599 0 003.037-1.671 3.599 3.599 0 004.295-4.297A3.6 3.6 0 0021 11.998a3.6 3.6 0 00-1.67-3.035v-.002a3.599 3.599 0 00-4.298-4.292A3.599 3.599 0 0011.997 3z" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With SVGOMG I was able to minify it a bit.
<path d="M11.997 3a3.599 3.599 0 00-3.044 1.682 3.599 3.599 0 00-.908-.095 3.599 3.599 0 00-2.411 1.051 3.6 3.6 0 00-.947 3.318A3.6 3.6 0 003 12.004a3.6 3.6 0 001.69 3.047 3.6 3.6 0 00.947 3.315 3.599 3.599 0 003.352.96A3.599 3.599 0 0012.002 21a3.599 3.599 0 003.037-1.671 3.599 3.599 0 004.295-4.297A3.6 3.6 0 0021 11.998a3.6 3.6 0 00-1.67-3.035v-.002a3.599 3.599 0 00-4.298-4.292A3.599 3.599 0 0011.997 3z" /> | |
<path d="M12 3a3.6 3.6 0 0 0-3.05 1.68 3.6 3.6 0 0 0-.9-.1 3.6 3.6 0 0 0-2.42 1.06 3.6 3.6 0 0 0-.94 3.32A3.6 3.6 0 0 0 3 12a3.6 3.6 0 0 0 1.69 3.05 3.6 3.6 0 0 0 .95 3.32 3.6 3.6 0 0 0 3.35.96A3.6 3.6 0 0 0 12 21a3.6 3.6 0 0 0 3.04-1.67 3.6 3.6 0 0 0 4.3-4.3A3.6 3.6 0 0 0 21 12a3.6 3.6 0 0 0-1.67-3.04v0a3.6 3.6 0 0 0-4.3-4.3A3.6 3.6 0 0 0 12 3z"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yeah. I forgot about that.
Anyway, can you guide me how to use SVGO? I wanted to try it myself, but the result was different from what you suggested.
Hmm, 🤔. Looks like I got something wrong.
But I see many icons have 2 pixel padding (and even 3 pixel). So, which one is correct? cc: @ericfennis, @locness3 |
@siarie I understand your confusion. I think we need to update the text a bit. It should be "Icons must have at least 1 pixel padding within the canvas.". We want a least 1 pixel empty around the canvas to make sure icons will render nicely. Otherwise some icons will look like they are "cut off".
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this icon you made is fine!
It's 1px minimum. |
Oh, the name... |
Hmm?. Did you mean this PR? |
wth I meant |
Well, I can't think of any other name other than this.
I don't know. |
badge-check seems fitting to me. |
Preview