Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed github icon api route issue #1117

Conversation

jguddas
Copy link
Member

@jguddas jguddas commented Apr 19, 2023

No description provided.

@karsa-mistmere
Copy link
Member

@jguddas: I've merged and rebased, but it doesn't seem to have done the job. :(

@jguddas
Copy link
Member Author

jguddas commented Apr 19, 2023

Here it works with the preview deployment:

icons/accessibility.svg

@karsa-mistmere
Copy link
Member

karsa-mistmere commented Apr 19, 2023

Ah, yes, possibly the issue is only that Vercel is still deploying the new app.

@jguddas
Copy link
Member Author

jguddas commented Apr 19, 2023

Ah, yes, possibly the issue is only that Vercel is still deploying the new app.

And GitHub is caching stuff as well ...

@karsa-mistmere
Copy link
Member

@jguddas: The build has finished, and things now seem to be working perfectly, thanks for the super quick fix, you're the best. ^_^

karsa-mistmere added a commit that referenced this pull request May 17, 2023
* Adds various badge icons, rebases verified as badge-check

* Add some more tags

* Revert "fix: fixed github icon api route issue (#1117)"

This reverts commit 49bd49b.

* manually revert merge

* manually optimize badge shape

* Update icons/circle-dollar-sign.svg

Co-authored-by: Jakob Guddas <[email protected]>

---------

Co-authored-by: Karsa <[email protected]>
Co-authored-by: Jakob Guddas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants