feat: added backdrop to gh-icon #1097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Wow, great work! Once again, this is going to be super useful with some PRs. :)
I have only one qualm with this, and that's using red, since it clashes with the path colors. How about the suggestion below + rearranging the "backdrop" to be the topmost layer?
That way we'd have something like this:
Not a perfect solution either, as the shadows look pretty similar to the backdrop, alternatively we could use a palette of colours for the paths that's devoid of any reds.
karsa-mistmere
approved these changes
Apr 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a backdrop, so you can see the difference that is introduced by the PR.