Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sysrst_ctrl, adc_ctrl] Convert collated edge based interrupt to level #21832

Closed
2 tasks done
msfschaffner opened this issue Mar 5, 2024 · 0 comments · Fixed by #21934
Closed
2 tasks done

[sysrst_ctrl, adc_ctrl] Convert collated edge based interrupt to level #21832

msfschaffner opened this issue Mar 5, 2024 · 0 comments · Fixed by #21934
Assignees
@msfschaffner
Labels
IP:adc_ctrl IP:sysrst_ctrl
Milestone
Earlgrey-PROD.M2

Comments

@msfschaffner
Copy link
Contributor

msfschaffner commented Mar 5, 2024 •
edited
Loading

Description

Both sysrst_ctrl and adc_ctrl have collated interrupt registers, where all local causes are reported and then sent out via one interrupt signal.

This is not ideal from an API perspective, since multiple IRQ registers have to be cleared for the same cause, potentially leading to a race.

The recommendation is thus to convert the collated IRQs to status type for both IPs.
@msfschaffner msfschaffner self-assigned this Mar 5, 2024
@msfschaffner msfschaffner added this to the Earlgrey-PROD.M2 milestone Mar 5, 2024
@msfschaffner msfschaffner mentioned this issue Mar 5, 2024
Closed
9 tasks
msfschaffner added a commit to msfschaffner/opentitan that referenced this issue Mar 6, 2024
@msfschaffner
[adc_ctrl] Change collated IRQ to status type
2b17ad4 
Addresses part of lowRISC#21832

Signed-off-by: Michael Schaffner <[email protected]>
msfschaffner added a commit to msfschaffner/opentitan that referenced this issue Mar 6, 2024
@msfschaffner
[sysrst_ctrl] Change collated IRQ to status type
f7b1e91 
Addresses part of lowRISC#21832

Signed-off-by: Michael Schaffner <[email protected]>
@msfschaffner msfschaffner mentioned this issue Mar 6, 2024
Merged
msfschaffner added a commit to msfschaffner/opentitan that referenced this issue Mar 6, 2024
@msfschaffner
[adc_ctrl] Change collated IRQ to status type
cf4996e 
Addresses part of lowRISC#21832

Signed-off-by: Michael Schaffner <[email protected]>
msfschaffner added a commit to msfschaffner/opentitan that referenced this issue Mar 6, 2024
@msfschaffner
[sysrst_ctrl] Change collated IRQ to status type
bf0ce19 
Addresses part of lowRISC#21832

Signed-off-by: Michael Schaffner <[email protected]>
msfschaffner added a commit to msfschaffner/opentitan that referenced this issue Mar 6, 2024
@msfschaffner
[adc_ctrl] Change collated IRQ to status type
4cebef8 
Addresses part of lowRISC#21832

Signed-off-by: Michael Schaffner <[email protected]>
msfschaffner added a commit to msfschaffner/opentitan that referenced this issue Mar 6, 2024
@msfschaffner
[sysrst_ctrl] Change collated IRQ to status type
868b2bb 
Addresses part of lowRISC#21832

Signed-off-by: Michael Schaffner <[email protected]>
msfschaffner added a commit to msfschaffner/opentitan that referenced this issue Mar 7, 2024
@msfschaffner
[adc_ctrl] Change collated IRQ to status type
f22ecf8 
Addresses part of lowRISC#21832

Signed-off-by: Michael Schaffner <[email protected]>
msfschaffner added a commit to msfschaffner/opentitan that referenced this issue Mar 7, 2024
@msfschaffner
[sysrst_ctrl] Change collated IRQ to status type
c3d7e77 
Addresses part of lowRISC#21832

Signed-off-by: Michael Schaffner <[email protected]>
msfschaffner added a commit to msfschaffner/opentitan that referenced this issue Mar 7, 2024
@msfschaffner
[adc_ctrl] Change collated IRQ to status type
562bd3d 
Addresses part of lowRISC#21832

Signed-off-by: Michael Schaffner <[email protected]>
msfschaffner added a commit to msfschaffner/opentitan that referenced this issue Mar 7, 2024
@msfschaffner
[sysrst_ctrl] Change collated IRQ to status type
649d534 
Addresses part of lowRISC#21832

Signed-off-by: Michael Schaffner <[email protected]>
msfschaffner added a commit to msfschaffner/opentitan that referenced this issue Mar 7, 2024
@msfschaffner
[adc_ctrl] Change collated IRQ to status type
40cb9ec 
Addresses part of lowRISC#21832

Signed-off-by: Michael Schaffner <[email protected]>
msfschaffner added a commit to msfschaffner/opentitan that referenced this issue Mar 7, 2024
@msfschaffner
[sysrst_ctrl] Change collated IRQ to status type
ee7f796 
Addresses part of lowRISC#21832

Signed-off-by: Michael Schaffner <[email protected]>
msfschaffner added a commit to msfschaffner/opentitan that referenced this issue Mar 7, 2024
@msfschaffner
[sysrst_ctrl] Change collated IRQ to status type
cb8f375 
Addresses part of lowRISC#21832

Signed-off-by: Michael Schaffner <[email protected]>
msfschaffner added a commit to msfschaffner/opentitan that referenced this issue Mar 7, 2024
@msfschaffner
[sysrst_ctrl] Change collated IRQ to status type
322b8c8 
Addresses part of lowRISC#21832

Signed-off-by: Michael Schaffner <[email protected]>
This was referenced Mar 8, 2024
Closed
Closed
msfschaffner added a commit to msfschaffner/opentitan that referenced this issue Mar 8, 2024
@msfschaffner
[sysrst_ctrl] Rework IRQ sync mechanism
e823409 
This reworks the IRQ event synchronization in preparation for
converting the IRQ to status type, see lowRISC#21832.

Signed-off-by: Michael Schaffner <[email protected]>
msfschaffner added a commit to msfschaffner/opentitan that referenced this issue Mar 8, 2024
@msfschaffner
[sysrst_ctrl] Rework IRQ sync mechanism
d603d48 
This reworks the IRQ event synchronization in preparation for
converting the IRQ to status type, see lowRISC#21832.

Signed-off-by: Michael Schaffner <[email protected]>
msfschaffner added a commit to msfschaffner/opentitan that referenced this issue Mar 8, 2024
@msfschaffner
[sysrst_ctrl] Rework IRQ sync mechanism
a6a8894 
This reworks the IRQ event synchronization in preparation for
converting the IRQ to status type, see lowRISC#21832.

Signed-off-by: Michael Schaffner <[email protected]>
msfschaffner added a commit to msfschaffner/opentitan that referenced this issue Mar 8, 2024
@msfschaffner
[sysrst_ctrl] Rework IRQ sync mechanism
0819415 
This reworks the IRQ event synchronization in preparation for
converting the IRQ to status type, see lowRISC#21832.

Signed-off-by: Michael Schaffner <[email protected]>
msfschaffner added a commit to msfschaffner/opentitan that referenced this issue Mar 8, 2024
@msfschaffner
[sysrst_ctrl] Convert IRQ type to status
8df5833 
Fixes lowRISC#21832

Signed-off-by: Michael Schaffner <[email protected]>
msfschaffner added a commit to msfschaffner/opentitan that referenced this issue Mar 8, 2024
@msfschaffner
[sysrst_ctrl] Rework IRQ sync mechanism
f2346c4 
This reworks the IRQ event synchronization in preparation for
converting the IRQ to status type, see lowRISC#21832.

In particular, it moves tracking of the IRQs into the bus domain
so that a status interrupt can be created more readily.

This is done by:
1) moving the collated IRQ status regs into the bus domain
2) creating a similar IRQ synchronization module as in adc_ctrl

Note that the wakeup request is still created and tracked in the AON
domain as before.

Signed-off-by: Michael Schaffner <[email protected]>
msfschaffner added a commit to msfschaffner/opentitan that referenced this issue Mar 8, 2024
@msfschaffner
[sysrst_ctrl] Convert IRQ type to status
6b6b60b 
Fixes lowRISC#21832

Signed-off-by: Michael Schaffner <[email protected]>
@msfschaffner msfschaffner mentioned this issue Mar 8, 2024
Merged
msfschaffner added a commit to msfschaffner/opentitan that referenced this issue Mar 9, 2024
@msfschaffner
[sysrst_ctrl] Convert IRQ type to status
edb986e 
Fixes lowRISC#21832

Signed-off-by: Michael Schaffner <[email protected]>
msfschaffner added a commit to msfschaffner/opentitan that referenced this issue Mar 9, 2024
@msfschaffner
[sysrst_ctrl] Convert IRQ type to status
51094b5 
Fixes lowRISC#21832

Signed-off-by: Michael Schaffner <[email protected]>
msfschaffner added a commit to msfschaffner/opentitan that referenced this issue Mar 9, 2024
@msfschaffner
[sysrst_ctrl] Rework IRQ sync mechanism
261cf0f 
This reworks the IRQ event synchronization in preparation for
converting the IRQ to status type, see lowRISC#21832.

In particular, it moves tracking of the IRQs into the bus domain
so that a status interrupt can be created more readily.

This is done by:
1) moving the collated IRQ status regs into the bus domain
2) creating a similar IRQ synchronization module as in adc_ctrl

Note that the wakeup request is still created and tracked in the AON
domain as before.

Signed-off-by: Michael Schaffner <[email protected]>
msfschaffner added a commit to msfschaffner/opentitan that referenced this issue Mar 9, 2024
@msfschaffner
[sysrst_ctrl] Convert IRQ type to status
3185ffe 
Fixes lowRISC#21832

Signed-off-by: Michael Schaffner <[email protected]>
msfschaffner added a commit to msfschaffner/opentitan that referenced this issue Mar 9, 2024
@msfschaffner
[sysrst_ctrl] Rework IRQ sync mechanism
4c4ad47 
This reworks the IRQ event synchronization in preparation for
converting the IRQ to status type, see lowRISC#21832.

In particular, it moves tracking of the IRQs into the bus domain
so that a status interrupt can be created more readily.

This is done by:
1) moving the collated IRQ status regs into the bus domain
2) creating a similar IRQ synchronization module as in adc_ctrl

Note that the wakeup request is still created and tracked in the AON
domain as before.

Signed-off-by: Michael Schaffner <[email protected]>
msfschaffner added a commit to msfschaffner/opentitan that referenced this issue Mar 9, 2024
@msfschaffner
[sysrst_ctrl] Convert IRQ type to status
3c14caa 
Fixes lowRISC#21832

Signed-off-by: Michael Schaffner <[email protected]>
msfschaffner added a commit to msfschaffner/opentitan that referenced this issue Mar 9, 2024
@msfschaffner
[sysrst_ctrl] Convert IRQ type to status
892415e 
Fixes lowRISC#21832

Signed-off-by: Michael Schaffner <[email protected]>
msfschaffner added a commit to msfschaffner/opentitan that referenced this issue Mar 9, 2024
@msfschaffner
[sysrst_ctrl] Rework IRQ sync mechanism
6db0c09 
This reworks the IRQ event synchronization in preparation for
converting the IRQ to status type, see lowRISC#21832.

In particular, it moves tracking of the IRQs into the bus domain
so that a status interrupt can be created more readily.

This is done by:
1) moving the collated IRQ status regs into the bus domain
2) creating a similar IRQ synchronization module as in adc_ctrl

Note that the wakeup request is still created and tracked in the AON
domain as before.

Signed-off-by: Michael Schaffner <[email protected]>
msfschaffner added a commit to msfschaffner/opentitan that referenced this issue Mar 9, 2024
@msfschaffner
[sysrst_ctrl] Convert IRQ type to status
c9447ef 
Fixes lowRISC#21832

Signed-off-by: Michael Schaffner <[email protected]>
msfschaffner added a commit to msfschaffner/opentitan that referenced this issue Mar 11, 2024
@msfschaffner
[sysrst_ctrl] Convert IRQ type to status
dc190b1 
Fixes lowRISC#21832

Signed-off-by: Michael Schaffner <[email protected]>
msfschaffner added a commit to msfschaffner/opentitan that referenced this issue Mar 11, 2024
@msfschaffner
[sysrst_ctrl] Convert IRQ type to status
99dc06e 
Fixes lowRISC#21832

Signed-off-by: Michael Schaffner <[email protected]>
msfschaffner added a commit to msfschaffner/opentitan that referenced this issue Mar 11, 2024
@msfschaffner
[sysrst_ctrl] Convert IRQ type to status
66bb921 
Fixes lowRISC#21832

Signed-off-by: Michael Schaffner <[email protected]>
msfschaffner added a commit to msfschaffner/opentitan that referenced this issue Mar 11, 2024
@msfschaffner
[sysrst_ctrl] Rework IRQ sync mechanism
e48cfb4 
This reworks the IRQ event synchronization in preparation for
converting the IRQ to status type, see lowRISC#21832.

In particular, it moves tracking of the IRQs into the bus domain
so that a status interrupt can be created more readily.

This is done by:
1) moving the collated IRQ status regs into the bus domain
2) creating a similar IRQ synchronization module as in adc_ctrl

Note that the wakeup request is still created and tracked in the AON
domain as before.

Signed-off-by: Michael Schaffner <[email protected]>
msfschaffner added a commit to msfschaffner/opentitan that referenced this issue Mar 11, 2024
@msfschaffner
[sysrst_ctrl] Convert IRQ type to status
1379f7a 
Fixes lowRISC#21832

Signed-off-by: Michael Schaffner <[email protected]>
msfschaffner added a commit to msfschaffner/opentitan that referenced this issue Mar 11, 2024
@msfschaffner
[sysrst_ctrl] Convert IRQ type to status
fa5958a 
Fixes lowRISC#21832

Signed-off-by: Michael Schaffner <[email protected]>
msfschaffner added a commit to msfschaffner/opentitan that referenced this issue Mar 11, 2024
@msfschaffner
[sysrst_ctrl] Convert IRQ type to status
eee8470 
Fixes lowRISC#21832

Signed-off-by: Michael Schaffner <[email protected]>
a-will pushed a commit to msfschaffner/opentitan that referenced this issue Mar 11, 2024
@msfschaffner @a-will
[sysrst_ctrl] Convert IRQ type to status
9680f67 
Fixes lowRISC#21832

Signed-off-by: Michael Schaffner <[email protected]>
msfschaffner added a commit that referenced this issue Mar 12, 2024
@msfschaffner
[sysrst_ctrl] Rework IRQ sync mechanism
dcce044 
This reworks the IRQ event synchronization in preparation for
converting the IRQ to status type, see #21832.

In particular, it moves tracking of the IRQs into the bus domain
so that a status interrupt can be created more readily.

This is done by:
1) moving the collated IRQ status regs into the bus domain
2) creating a similar IRQ synchronization module as in adc_ctrl

Note that the wakeup request is still created and tracked in the AON
domain as before.

Signed-off-by: Michael Schaffner <[email protected]>
msfschaffner added a commit that referenced this issue Mar 12, 2024
@msfschaffner
[sysrst_ctrl] Convert IRQ type to status
bfd9e18 
Fixes #21832

Signed-off-by: Michael Schaffner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@msfschaffner msfschaffner

Labels
IP:adc_ctrl IP:sysrst_ctrl
Projects
None yet
Milestone
Earlgrey-PROD.M2
Development

Successfully merging a pull request may close this issue.

[sysrst_ctrl] Rework IRQ sync mechanism and convert IRQ to status type msfschaffner/opentitan
1 participant
@msfschaffner