Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): use tslint.build.json as the base #964

Merged
merged 1 commit into from
Feb 5, 2018
Merged

Conversation

raymondfeng
Copy link
Contributor

@raymondfeng raymondfeng commented Feb 5, 2018

This fixes a regression from 15dd2db

Checklist

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • Related API Documentation was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in packages/example-* were updated

Copy link
Contributor

@virkt25 virkt25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just need to disable the rule in example-getting-started so it doesn't fail on CI.

@raymondfeng
Copy link
Contributor Author

Adding ./packages/cli/test/sandbox/**/* to the exclude list for tslint to avoid CI failure.

@raymondfeng raymondfeng merged commit 22f8e05 into master Feb 5, 2018
@raymondfeng raymondfeng deleted the fix-tslint branch February 5, 2018 23:09
@bajtos
Copy link
Member

bajtos commented Feb 6, 2018

This fixes a regression from 15dd2db

And creates another regression - the VSCode plugin for tslint report even more warnings now:

Warning: The 'await-promise' rule requires type information.
Warning: The 'no-floating-promises' rule requires type information.
Warning: The 'no-unused-variable' rule requires type information.
Warning: The 'no-void-expression' rule requires type information.

We need to discuss this in more depth to find a solution that will work for both npm run tslint and the VSCode plugin.

@bajtos
Copy link
Member

bajtos commented Feb 6, 2018

Ideally, we should use TypeScript's noUnusedLocals settings instead of tslint, unfortunately that's not possible yet because of microsoft/TypeScript#21673

raymondfeng added a commit that referenced this pull request Feb 6, 2018
This is a follow-up to #964.

Two config files are in place now:
- tslint.build.json for CLI build scripts
- tslint.json for vscode
raymondfeng added a commit that referenced this pull request Feb 6, 2018
This is a follow-up to #964.

Two config files are in place now:
- tslint.build.json for CLI build scripts
- tslint.json for vscode
raymondfeng added a commit that referenced this pull request Feb 6, 2018
This is a follow-up to #964.

Two config files are in place now:
- tslint.build.json for CLI build scripts
- tslint.json for vscode
raymondfeng added a commit that referenced this pull request Feb 8, 2018
This is a follow-up to #964.

Two config files are in place now:
- tslint.build.json for CLI build scripts
- tslint.json for vscode
raymondfeng added a commit that referenced this pull request Feb 8, 2018
This is a follow-up to #964.

Two config files are in place now:
- tslint.build.json for CLI build scripts
- tslint.json for vscode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants