-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(build): use tslint.build.json
as the base
#964
Conversation
dacfde2
to
8cc3d73
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Just need to disable the rule in example-getting-started
so it doesn't fail on CI.
The regression is caused by 15dd2db
8cc3d73
to
ad9ecd5
Compare
Adding |
And creates another regression - the VSCode plugin for tslint report even more warnings now:
We need to discuss this in more depth to find a solution that will work for both |
Ideally, we should use TypeScript's |
This is a follow-up to #964. Two config files are in place now: - tslint.build.json for CLI build scripts - tslint.json for vscode
This is a follow-up to #964. Two config files are in place now: - tslint.build.json for CLI build scripts - tslint.json for vscode
This is a follow-up to #964. Two config files are in place now: - tslint.build.json for CLI build scripts - tslint.json for vscode
This is a follow-up to #964. Two config files are in place now: - tslint.build.json for CLI build scripts - tslint.json for vscode
This is a follow-up to #964. Two config files are in place now: - tslint.build.json for CLI build scripts - tslint.json for vscode
This fixes a regression from 15dd2db
Checklist
npm test
passes on your machinepackages/cli
were updatedpackages/example-*
were updated