chore: separate tslint config files for build and vscode

[raymondfeng]

This is a follow-up to #964.

Two config files are in place now:

• tslint.build.json for CLI build scripts
• tslint.json for vscode

Checklist

• npm test passes on your machine
• New tests added or existing tests modified to cover all changes
• Code conforms with the style guide
• Related API Documentation was updated
• Affected artifact templates in packages/cli were updated
• Affected example projects in packages/example-* were updated

[virkt25]

IIUC, this is an undo of the previous commit. But we will end up without a check for unused import again.

Is it possible to update the package.json "tslint" script to pass it tslint.build.json as the config? (And that might remove the warning for tslint plugin for VSCode).

[raymondfeng]

IIUC, this is an undo of the previous commit. But we will end up without a check for unused import again.

Not really. Please note that CLI build uses tslint.build.json and it catches violation of unused vars.

[virkt25]

By CLI do you mean @loopback/build and the package.json file?

[raymondfeng]

By CLI do you mean @loopback/build and the package.json file?

npm run lint which uses lb-tslint.

[virkt25]

I see. So it doesn't pick it up the the top level tslint.json which extends tslint.common.json? That seems strange but ok. As long as it catches unused imports :)

Maybe wait till @bajtos / @kjdelisle have a chance to review this as well before merging.

[raymondfeng]

Yes, lb-tslint uses tslint.build.json over tslint.json. This way, vscode uses tslint.json while our build uses tslint.build.json.

[bajtos]

This is great, thank you @raymondfeng for fixing the problems introduced by your previous PR 👏

I have checked out your feature branch and verified that:

• vscode-tslint does not report any warnings
• unused variables are reported by npm run tslint

I think you have a bug in the tslint.build.json template (see my comment below).

Other than that, this patch LGTM 👍

[bajtos]

I think you have a typo here - are you sure that tslint.build.json should be extending tsconfig.build.json? I think you meant to extend tslint.build.json instead.

[raymondfeng]

Good catch. Fixed.