Skip to content

Commit

Permalink
fix(build): move no-unused-variables to tslint.build.json
Browse files Browse the repository at this point in the history
In the latest version of tslint, the rule "no-unused-variables" requires
type information and therefore cannot be run on the fly from VS Code.

This commit move the configuration of "no-unused-variables"
from tsling.common.json to tslint.build.json to avoid warnings printed
to VS Code console:

    Warning: The 'no-unused-variable' rule requires type information.
  • Loading branch information
bajtos committed Jan 15, 2018
1 parent 34a63d5 commit 15dd2db
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
2 changes: 1 addition & 1 deletion packages/build/config/tslint.build.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,12 @@
"rules": {
// These rules find errors related to TypeScript features.


// These rules catch common errors in JS programming or otherwise
// confusing constructs that are prone to producing bugs.

"await-promise": true,
"no-floating-promises": true,
"no-unused-variable": true,
"no-void-expression": [true, "ignore-arrow-function-shorthand"]
}
}
1 change: 0 additions & 1 deletion packages/build/config/tslint.common.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
"no-shadowed-variable": true,
"no-string-throw": true,
"no-unused-expression": true,
"no-unused-variable": true,
"no-var-keyword": true,
"triple-equals": [true, "allow-null-check", "allow-undefined-check"]
}
Expand Down

0 comments on commit 15dd2db

Please sign in to comment.