Improve the city dialog unit lists #1201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The icon_list widget is only used to display a list of units. Rename it as such. Also implement the context menu and filling the list directly in the class instead of externally, saving a few lines of code and fixing longturn#1200. Closes longturn#1200.
It was previously operating on single items. In order to allow for multiple selection, we need to handle this at the list level instead. See longturn#805.
It allows for much faster operation than dealing with each unit individually (for instance, upgrading all units of a certain type). Multiple selection uses the OS' standard shortcuts and also accepts dragging the mouse over multiple units to select them all. Closes longturn#805.
This class had become so small that it was no longer worth it.
jwrober
approved these changes
Aug 7, 2022
There was a problem hiding this comment.
1200 is completely fixed, however 805 is only partially done. The issue asks for an activate unit and activate unit and close option similar to what fc gtk client supports. Right now we get activate, which when selected closes the city dialog. I am ok with approving this PR, but we should open a subsequent issue enhancement asking for a change to the selection menu.
I thought we had agreed in #805 that multiple selection also solved the use case? |
Oh I missed that. I didn't scroll down. I am good then. I will need to update the manual, this is not totally obvious |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #805
Closes #1200
Test plan