Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Right-clicking the supported units panel interacts with the present units panel #1200

Closed
lmoureaux opened this issue Aug 6, 2022 · 0 comments · Fixed by #1201
Closed

Right-clicking the supported units panel interacts with the present units panel #1200

lmoureaux opened this issue Aug 6, 2022 · 0 comments · Fixed by #1201
Assignees
@lmoureaux
Labels
bug Something isn't working gui This issue requires changes to the user interface
Milestone
v3.0-stable

Comments

@lmoureaux
Copy link
Contributor

Describe the bug

In the city dialog, right-clicking on a unit in the list of supported units pops up the menu in the list of present units.

To Reproduce
Steps to reproduce the behavior:

  1. Open a city with both present and supported units
  2. Right click on a supported unit
  3. See the menu appearing next to the present unit at the same index in the list

Expected behavior

The menu opens near the mouse

Platform and version (please complete the following information):

  • OS: any
  • Freeciv21 version: 3.0-beta3
  • Ruleset/Longturn game (if applicable): any and all
@lmoureaux lmoureaux added bug Something isn't working gui This issue requires changes to the user interface labels Aug 6, 2022
@lmoureaux lmoureaux added this to the v3.0-beta.4 milestone Aug 6, 2022
@lmoureaux lmoureaux self-assigned this Aug 6, 2022
lmoureaux added a commit to lmoureaux/freeciv21 that referenced this issue Aug 6, 2022
@lmoureaux
Turn icon_list into unit_list_widget and enhance menu handling
c34458b 
The icon_list widget is only used to display a list of units. Rename it as
such. Also implement the context menu and filling the list directly in the
class instead of externally, saving a few lines of code and fixing longturn#1200.

Closes longturn#1200.
@lmoureaux lmoureaux mentioned this issue Aug 6, 2022
Merged
@jwrober jwrober closed this as completed in 31b59ad Aug 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lmoureaux lmoureaux

Labels
bug Something isn't working gui This issue requires changes to the user interface
Projects
None yet
Milestone
v3.0-stable
Development

Successfully merging a pull request may close this issue.

Improve the city dialog unit lists lmoureaux/freeciv21
1 participant
@lmoureaux