Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Activating units in city window #805

Closed
Corbeau-1 opened this issue Jan 6, 2022 · 3 comments · Fixed by #1201
Closed

Activating units in city window #805

Corbeau-1 opened this issue Jan 6, 2022 · 3 comments · Fixed by #1201
Labels
bug Something isn't working gui This issue requires changes to the user interface
Milestone
v3.0-stable

Comments

@Corbeau-1
Copy link
Contributor

In city window:

Current state:
double-clicking or right-click-"activate" on a unit activates unit and closes city window

Problem:
If I want to activate more units from the same city, I have to reopen the city window for each unit

Desired behaviour:
Same as in GTK: have separate commands
"Activate" - activates unit but does not exit city window
"Activate and exit" - what it says
@Corbeau-1 Corbeau-1 added enhancement New feature or request Untriaged This issue or PR needs triaging labels Jan 6, 2022
@jwrober jwrober added bug Something isn't working gui This issue requires changes to the user interface and removed enhancement New feature or request Untriaged This issue or PR needs triaging labels Jan 7, 2022
@jwrober
Copy link
Collaborator

jwrober commented Jan 7, 2022

I see this as more of a UI/UX bug.

@lmoureaux
Copy link
Contributor

I think the proper solution would be to allow selecting multiple units from the list with the usual Ctrl and Shift shortcuts.

@Corbeau-1
Copy link
Contributor Author

That works, too.

@jwrober jwrober added this to the v3.0-beta.2 milestone Jan 25, 2022
@lmoureaux lmoureaux modified the milestones: v3.0-beta.2, v3.0-beta.3 Jul 8, 2022
lmoureaux added a commit to lmoureaux/freeciv21 that referenced this issue Aug 3, 2022
@lmoureaux
Use std::vector for the list of focused units
1a04505 
I would like to have some decent container to use in longturn#805 (if several units are
selected, I want the right click menu to apply to all of them, which will
require a container).

Change focus_units (=get_units_in_focus()) to be a std::vector<unit *>. This
has implications in a lot of places, which are also modified to use
std::vector.
@lmoureaux lmoureaux mentioned this issue Aug 3, 2022
Merged
psampathkumar pushed a commit that referenced this issue Aug 4, 2022
@lmoureaux @psampathkumar
Use std::vector for the list of focused units
ee1e43a 
I would like to have some decent container to use in #805 (if several units are
selected, I want the right click menu to apply to all of them, which will
require a container).

Change focus_units (=get_units_in_focus()) to be a std::vector<unit *>. This
has implications in a lot of places, which are also modified to use
std::vector.
lmoureaux added a commit to lmoureaux/freeciv21 that referenced this issue Aug 6, 2022
@lmoureaux
Move unit_list_widget context menu handling to the widget
452ecb0 
It was previously operating on single items. In order to allow for multiple
selection, we need to handle this at the list level instead.

See longturn#805.
lmoureaux added a commit to lmoureaux/freeciv21 that referenced this issue Aug 6, 2022
@lmoureaux
Allow multiple selection in the city screen unit lists
1a0184f 
It allows for much faster operation than dealing with each unit individually
(for instance, upgrading all units of a certain type). Multiple selection uses
the OS' standard shortcuts and also accepts dragging the mouse over multiple
units to select them all.

Closes longturn#805.
@lmoureaux lmoureaux mentioned this issue Aug 6, 2022
Merged
jwrober pushed a commit that referenced this issue Aug 7, 2022
@lmoureaux @jwrober
Move unit_list_widget context menu handling to the widget
bd27df2 
It was previously operating on single items. In order to allow for multiple
selection, we need to handle this at the list level instead.

See #805.
jwrober pushed a commit that referenced this issue Aug 7, 2022
@lmoureaux @jwrober
Allow multiple selection in the city screen unit lists
dfd9d38 
It allows for much faster operation than dealing with each unit individually
(for instance, upgrading all units of a certain type). Multiple selection uses
the OS' standard shortcuts and also accepts dragging the mouse over multiple
units to select them all.

Closes #805.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working gui This issue requires changes to the user interface
Projects
None yet
Milestone
v3.0-stable
Development

Successfully merging a pull request may close this issue.

Improve the city dialog unit lists lmoureaux/freeciv21
3 participants
@lmoureaux @jwrober @Corbeau-1